From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Raymond Hackley <raymondhackley@protonmail.com>
Cc: linux-kernel@vger.kernel.org,
Markuss Broks <markuss.broks@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Stephan Gerhold <stephan@gerhold.net>,
Nikita Travkin <nikita@trvn.ru>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 0/3] Add support for Imagis IST3038 and clarify the usage of protocol_b
Date: Mon, 8 Jul 2024 10:10:02 -0700 [thread overview]
Message-ID: <Zowdam9nm4I7FSk3@google.com> (raw)
In-Reply-To: <20240613025631.5425-1-raymondhackley@protonmail.com>
On Thu, Jun 13, 2024 at 02:56:46AM +0000, Raymond Hackley wrote:
> Imagis IST3038 is another variant of Imagis IST3038 IC, which has
> a different register interface from IST3038C (possibly firmware defined).
>
> Unlike IST3038C/IST3032C, IST3038 has different registers for commands,
> which means IST3038 doesn't use protocol B.
> Similar to IST3032C and maybe the other variants, IST3038 has touch keys
> support, which provides KEY_APPSELECT and KEY_BACK.
>
> Add support for IST3038 with touch keys.
>
> protocol_b is a property, which tells Imagis panel to use a different
> format for coordinates.
>
> IST30XXC series is known for using protocol B, while the other series
> aren't. Note this could be confusing, unlike the model name implies.
>
> Adjust the usage of protocol_b to avoid confusion.
>
> ---
> v2: Sort the compatible enties in alphabetical order.
> Document the binding before using in the driver.
>
Applied the lot, thank you.
--
Dmitry
prev parent reply other threads:[~2024-07-08 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 2:56 [PATCH v2 0/3] Add support for Imagis IST3038 and clarify the usage of protocol_b Raymond Hackley
2024-06-13 2:56 ` [PATCH v2 1/3] input/touchscreen: imagis: Clarify " Raymond Hackley
2024-06-13 2:57 ` [PATCH v2 2/3] dt-bindings: input/touchscreen: imagis: Document ist3038 Raymond Hackley
2024-06-13 9:13 ` Krzysztof Kozlowski
2024-06-13 2:57 ` [PATCH v2 3/3] input/touchscreen: imagis: Add supports for Imagis IST3038 Raymond Hackley
2024-07-08 17:10 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zowdam9nm4I7FSk3@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=nikita@trvn.ru \
--cc=raymondhackley@protonmail.com \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.