From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Gene Bright" <gene@cyberlight.us>,
"Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Daniel P . Smith" <dpsmith@apertussolutions.com>,
"Alejandro Vallejo" <alejandro.vallejo@cloud.com>
Subject: Re: [PATCH 2/2] x86/efi: Unlock NX if necessary
Date: Tue, 23 Jul 2024 12:31:15 +0200 [thread overview]
Message-ID: <Zp-Gc6oCppUymzqm@mail-itl> (raw)
In-Reply-To: <Zp-FHHYmCj_Tu7DQ@mail-itl>
[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]
On Tue, Jul 23, 2024 at 12:25:32PM +0200, Marek Marczykowski-Górecki wrote:
> On Mon, Jul 22, 2024 at 11:18:38AM +0100, Andrew Cooper wrote:
> > EFI systems can run with NX disabled, as has been discovered on a Broadwell
> > Supermicro X10SRM-TF system.
> >
> > Prior to commit fc3090a47b21 ("x86/boot: Clear XD_DISABLE from the early boot
> > path"), the logic to unlock NX was common to all boot paths, but that commit
> > moved it out of the native-EFI booth path.
> >
> > Have the EFI path attempt to unlock NX, rather than just blindly refusing to
> > boot when CONFIG_REQUIRE_NX is active.
> >
> > Fixes: fc3090a47b21 ("x86/boot: Clear XD_DISABLE from the early boot path")
> > Link: https://xcp-ng.org/forum/post/80520
> > Reported-by: Gene Bright <gene@cyberlight.us>
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Ugh, wrong copy paste:
Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
I should finish my coffee first...
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-07-23 10:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 10:18 [PATCH 0/2] x86/efi: Fix booting when NX is disabled Andrew Cooper
2024-07-22 10:18 ` [PATCH 1/2] x86/efi: Simplify efi_arch_cpu() a little Andrew Cooper
2024-07-23 10:23 ` Marek Marczykowski-Górecki
2024-07-23 13:47 ` Alejandro Vallejo
2024-07-24 5:42 ` Jan Beulich
2024-07-24 13:28 ` Alejandro Vallejo
2024-07-24 13:47 ` Jan Beulich
2024-07-24 13:42 ` Jan Beulich
2024-07-22 10:18 ` [PATCH 2/2] x86/efi: Unlock NX if necessary Andrew Cooper
2024-07-22 10:43 ` Jan Beulich
2024-07-22 17:04 ` Andrew Cooper
2024-07-22 17:38 ` Andrew Cooper
2024-07-23 6:34 ` Jan Beulich
2024-07-23 10:25 ` Marek Marczykowski-Górecki
2024-07-23 10:31 ` Marek Marczykowski-Górecki [this message]
2024-07-23 14:00 ` Alejandro Vallejo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zp-Gc6oCppUymzqm@mail-itl \
--to=marmarek@invisiblethingslab.com \
--cc=JBeulich@suse.com \
--cc=alejandro.vallejo@cloud.com \
--cc=andrew.cooper3@citrix.com \
--cc=dpsmith@apertussolutions.com \
--cc=gene@cyberlight.us \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.