From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [213.95.27.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EFC115098E for ; Tue, 23 Jul 2024 12:19:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.27.120 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721737198; cv=none; b=jEJUx5zHQfxH9ljvwc3HnCKTkFJnvY0H8CoqlDXNbP4D3GqvIlQmrTSoKiCScv8Q1PLKQxSKwYZ7QopO+uEnhnwwmNfsoAX+iQVAhRwxOd0+3B52Qux1jffgWwn4A7lnma+qZijWslaARcqXEdLOf5Sps2VxBMmxV8ibRtaeWss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721737198; c=relaxed/simple; bh=JtMjqtvxffW8N5gVe9lQLts48z9o+wT7eyY0bgi2Zxk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SSWqt5c12X0/qzNbrz/1wfeSDe4CyECbikB7qd0tpoRjGz3Kpz+TirqCN02ek1Z/NaXyK/Z1CtOii57zBW9fVSUHLXFOff6IhCUcqIEFBeRomLMnlnn+fkQ24lLlwV029hdHFHINu5hiFuTC/EBLIYBkYhX+uResUcBKE9qsa/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=gnumonks.org; arc=none smtp.client-ip=213.95.27.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gnumonks.org Received: from [46.6.251.194] (port=5530 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sWEUg-000bAA-Df; Tue, 23 Jul 2024 14:19:52 +0200 Date: Tue, 23 Jul 2024 14:19:47 +0200 From: Pablo Neira Ayuso To: Kerin Millar Cc: Slavko , netfilter ML Subject: Re: Sets update Message-ID: References: <20240721132337.29d2fbc9@bonifac.skk> <4a9d6e4b-61e8-4aa6-ac50-8cbb9357e398@app.fastmail.com> <20240723092439.7b9f7b58@bonifac.skk> <205f7dcd-150c-42a7-83c0-6d4a36a5f2d5@app.fastmail.com> Precedence: bulk X-Mailing-List: netfilter@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <205f7dcd-150c-42a7-83c0-6d4a36a5f2d5@app.fastmail.com> X-Spam-Score: -1.9 (-) On Tue, Jul 23, 2024 at 12:32:50PM +0100, Kerin Millar wrote: > On Tue, 23 Jul 2024, at 10:39 AM, Pablo Neira Ayuso wrote: > > On Tue, Jul 23, 2024 at 09:24:39AM +0200, Slavko wrote: > > [...] > >> (The host has >6 GB of free RAM, the list has ~1700 items) > >> > >> Initially i blame IP duplicates in downloaded list of IPs, but that was > >> unrelated to this error. When i remove the first "add" and "delete" > >> lines from script (thus just one "add"), it works. After initial fill it > >> works with all three commands (add+delete+add) on already filled set > >> and even when i flush that set, it still works. Only first fill (after > >> boot) ends with that error. > >> > >> When i delete and create that set, i got "Out of memory" again, the set > >> is defined as:: > >> > >> table inet fw4 { > >> set myset { > >> type ipv4_addr > >> last counter > >> timeout 2d > >> } > >> } > >> > >> I tried to add "size" into it, but that doesn't help. > >> > >> I roughly remember, that i read something about some memory limit in > >> container (i am not in container), but i am not able to find that > >> again to check if that is problem. > >> > >> Please, what can cause that initial fill error, how i can debug/solve > >> it? > > > > Kernel is likely missing this patch: > > > > commit fa23e0d4b756d25829e124d6b670a4c6bbd4bf7e > > Author: Florian Westphal > > Date: Wed May 8 14:52:47 2024 +0200 > > > > netfilter: nf_tables: allow clone callbacks to sleep > > Would it be safe to backport the following two commits to linux-6.6.y in isolation? > > 3c13725f43dcf43ad8a9bcd6a9f12add19a8f93e (bail out if stateful expression provides no .clone) > fa23e0d4b756d25829e124d6b670a4c6bbd4bf7e (allow clone callbacks to sleep) I have enqueued those for -stable submission.