From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH 2/2] hwmon: (max16065) Fix alarm attributes
Date: Mon, 22 Jul 2024 03:30:56 +0000 [thread overview]
Message-ID: <Zp3ScBZOJQixuFN9@google.com> (raw)
In-Reply-To: <20240721193506.2330006-2-linux@roeck-us.net>
On Sun, Jul 21, 2024 at 12:35:06PM -0700, Guenter Roeck wrote:
> Chips reporting overcurrent alarms report it in the second alarm register.
I can't understand the sentence. Not sure whether it needs to be rephrased or
not. s/overcurrent/overvoltage/.
> That means the second alarm register has to be read, even if the chip only
> supports 8 or fewer ADC channels.
>
> MAX16067 and MAX16068 report undervoltage and overvoltage alarms in
> separate registers. Fold register contents together to report both with
> the existing alarm attribute. This requires actually storing the chip type
> in struct max16065_data. Rename the variable 'chip' to match the variable
> name used in the probe function.
>
> Fixes: f5bae2642e3d ("hwmon: Driver for MAX16065 System Manager and compatibles")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
next prev parent reply other threads:[~2024-07-22 3:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 19:35 [PATCH 1/2] hwmon: (max16065) Fix overflows seen when writing limits Guenter Roeck
2024-07-21 19:35 ` [PATCH 2/2] hwmon: (max16065) Fix alarm attributes Guenter Roeck
2024-07-22 3:30 ` Tzung-Bi Shih [this message]
2024-07-22 3:48 ` Guenter Roeck
2024-07-22 5:47 ` Tzung-Bi Shih
2024-07-22 13:45 ` Guenter Roeck
2024-07-22 3:30 ` [PATCH 1/2] hwmon: (max16065) Fix overflows seen when writing limits Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zp3ScBZOJQixuFN9@google.com \
--to=tzungbi@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.