From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80334C3DA59 for ; Mon, 22 Jul 2024 12:44:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DCFAE10E0EC; Mon, 22 Jul 2024 12:44:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Q8e3lbHf"; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6BC4310E0EC; Mon, 22 Jul 2024 12:44:15 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id EA151CE0AD7; Mon, 22 Jul 2024 12:44:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05D27C116B1; Mon, 22 Jul 2024 12:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721652252; bh=b7uraR+kg3VECJVI+AKWtB20lyxc+lXXuEPrdL51Vcc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q8e3lbHfYFRQYkbWZvSkZTS4YkyNkdM4lxfrhmi2qUPQP65ffLrRI1bhsU0ucGjTB 4CwwBAMF+qhmSI2WJDcji4p8CeyPZZOYigiBtE39yLOtiTisb0QZgSCcVWxbukYRH7 agdwKVSiAAkpq4Cz3SAwm1gvJlXefqgKr5yDwlr7dcx/kI05YCqhG8OI/lSWDmAyTq PPwZnLaVJ60GA5lEXJC7EL9sd8N8kXiFhB+ixPuqLplV+GpCXGU65LbEn5J9TO1KMh NLz0zeI4g3CSacaMORmk0G2kxepYxJGmiuja+3885dPB4FCRanYK2KGrwUT3yIkFpX Wi5wHsbgBEdcQ== Date: Mon, 22 Jul 2024 08:44:10 -0400 From: Sasha Levin To: Hamza Mahfooz Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tom Chung , Sun peng Li , Jerry Zuo , Daniel Wheeler , Alex Deucher , harry.wentland@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, alex.hung@amd.com, roman.li@amd.com, mario.limonciello@amd.com, joshua@froggi.es, wayne.lin@amd.com, srinivasan.shanmugam@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH AUTOSEL 6.9 11/22] drm/amd/display: Reset freesync config before update new state Message-ID: References: <20240716142519.2712487-1-sashal@kernel.org> <20240716142519.2712487-11-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tue, Jul 16, 2024 at 10:48:03AM -0400, Hamza Mahfooz wrote: >Hi Sasha, > >On 7/16/24 10:24, Sasha Levin wrote: >>From: Tom Chung >> >>[ Upstream commit 6b8487cdf9fc7bae707519ac5b5daeca18d1e85b ] >> >>[Why] >>Sometimes the new_crtc_state->vrr_infopacket did not sync up with the >>current state. >>It will affect the update_freesync_state_on_stream() does not update >>the state correctly. >> >>[How] >>Reset the freesync config before get_freesync_config_for_crtc() to >>make sure we have the correct new_crtc_state for VRR. > >Please drop this patch from the stable queue entirely, since it has >already been reverted (as of commit dc1000bf463d ("Revert >"drm/amd/display: Reset freesync config before update new state"")). Dropped, thanks! -- Thanks, Sasha