All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mips: sibyte: add missing MODULE_DESCRIPTION() macro
Date: Tue, 23 Jul 2024 09:48:08 +0200	[thread overview]
Message-ID: <Zp9gOOUp3ZWXY/B8@alpha.franken.de> (raw)
In-Reply-To: <20240718-md-mips-arch-mips-sibyte-common-v1-1-49b29b0555eb@quicinc.com>

On Thu, Jul 18, 2024 at 04:17:52PM -0700, Jeff Johnson wrote:
> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
> description is missing"), a module without a MODULE_DESCRIPTION() will
> result in a warning with make W=1. The following warning is being
> observed when ARCH=mips and CONFIG_SIBYTE_TBPROF=m:
> 
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/mips/sibyte/common/sb_tbprof.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> I'm trying to fix all of these issues in 6.11, so please take this
> through your "for current" path instead of your "for next" path. If
> you don't have a "for current" path, Greg KH has indicated he'll pick
> up the stragglers before the 6.11 rc-final.
> ---
>  arch/mips/sibyte/common/sb_tbprof.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/sibyte/common/sb_tbprof.c b/arch/mips/sibyte/common/sb_tbprof.c
> index af5333986900..149a9151bc0b 100644
> --- a/arch/mips/sibyte/common/sb_tbprof.c
> +++ b/arch/mips/sibyte/common/sb_tbprof.c
> @@ -589,4 +589,5 @@ module_exit(sbprof_tb_cleanup);
>  
>  MODULE_ALIAS_CHARDEV_MAJOR(SBPROF_TB_MAJOR);
>  MODULE_AUTHOR("Ralf Baechle <ralf@linux-mips.org>");
> +MODULE_DESCRIPTION("Support for ZBbus profiling");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: 51835949dda3783d4639cfa74ce13a3c9829de00
> change-id: 20240718-md-mips-arch-mips-sibyte-common-7c51d90b31f2

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

      reply	other threads:[~2024-07-23  7:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18 23:17 [PATCH] mips: sibyte: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-07-23  7:48 ` Thomas Bogendoerfer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zp9gOOUp3ZWXY/B8@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=quic_jjohnson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.