From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jordan Justen <jordan.l.justen@intel.com>,
"Souza, Jose" <jose.souza@intel.com>, <ashutosh.dixit@intel.com>
Cc: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Dave Airlie" <airlied@gmail.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Oded Gabbay" <ogabbay@kernel.org>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, dim-tools@lists.freedesktop.org
Subject: Re: [PULL] drm-xe-next-fixes v2
Date: Thu, 11 Jul 2024 17:33:27 -0400 [thread overview]
Message-ID: <ZpBPp8QDFCS5S5L4@intel.com> (raw)
In-Reply-To: <172073334417.323134.379928595741854448@jljusten-skl>
On Thu, Jul 11, 2024 at 02:29:04PM -0700, Jordan Justen wrote:
> On 2024-07-11 08:18:18, Rodrigo Vivi wrote:
> > Hi Dave and Sima,
> >
> > This is a v2 of https://lore.kernel.org/intel-xe/Zo2sO4t32dxqy6Q7@intel.com/
> >
> > v2 - Removed Thomas' write-back caching mode patch since Lucas will propagete
> > that through drm-xe-fixes towards 6.10. So we remove the amount of patch
> > duplication.
> >
> > Again, it is important to highlight the uapi rename present in this
> > pull-request.
> > Mesa is aligned and waiting to merge their side:
> > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30027
> >
> > Since this uapi was recently merged, after we get both sides propagate
> > there won't be any kernel or mesa releases with the old bad naming.
> > So we should be good.
>
> This looks to be a simple rename, and it appears that the binary
> interface is functionally the same. So, even if there was a Mesa
> release using the old header, it should function fine with the
> interface to the kernel regardless of which header the kernel used.
>
> If the binary interface had changed, I'm not sure an argument of "no
> kernel or Mesa releases have happened" would be a good way to justify
> such a change. Luckily that is not the case here anyway.
Agreed. If it was that drastic we should never do and this argument
shouldn't apply.
But it is not so transparent as a full rename because there's one
sysfs file name that also changed with the rest of the renaming. :/
>
> -Jordan
prev parent reply other threads:[~2024-07-11 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 15:18 [PULL] drm-xe-next-fixes v2 Rodrigo Vivi
2024-07-11 21:29 ` Jordan Justen
2024-07-11 21:33 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpBPp8QDFCS5S5L4@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=airlied@gmail.com \
--cc=ashutosh.dixit@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dim-tools@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jordan.l.justen@intel.com \
--cc=jose.souza@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ogabbay@kernel.org \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.