From: Carlos Llamas <cmllamas@google.com>
To: Leesoo Ahn <lsahn@ooseel.net>
Cc: "Leesoo Ahn" <lsahn@wewakecorp.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <brauner@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] android: binder: print error message on failure of creating proc file
Date: Fri, 12 Jul 2024 04:01:20 +0000 [thread overview]
Message-ID: <ZpCqkPIOCsnmf5lF@google.com> (raw)
In-Reply-To: <20240712032140.4012667-1-lsahn@wewakecorp.com>
On Fri, Jul 12, 2024 at 12:21:40PM +0900, Leesoo Ahn wrote:
> It better prints out an error message to give more information if
> calling debugfs_create_file() is failure and the return value has an
> error code.
>
> Signed-off-by: Leesoo Ahn <lsahn@ooseel.net>
> ---
What are you trying to fix? My understanding is that users of the
debugfs API can safely ignore any errors and move on. IMO it doesn't
make sense to add this without a real reason.
--
Carlos Llamas
next prev parent reply other threads:[~2024-07-12 4:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 3:21 [PATCH] android: binder: print error message on failure of creating proc file Leesoo Ahn
2024-07-12 4:01 ` Carlos Llamas [this message]
2024-07-12 5:39 ` Greg Kroah-Hartman
2024-07-12 6:52 ` Leesoo Ahn
2024-07-12 7:19 ` Greg Kroah-Hartman
2024-07-12 7:33 ` Leesoo Ahn
2024-07-12 5:40 ` Greg Kroah-Hartman
2024-07-12 5:54 ` Leesoo Ahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpCqkPIOCsnmf5lF@google.com \
--to=cmllamas@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahn@ooseel.net \
--cc=lsahn@wewakecorp.com \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.