All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Andi Shyti <andi.shyti@kernel.org>,
	Jean Delvare <jdelvare@suse.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Guenter Roeck <linux@roeck-us.net>,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH v3 2/2] i2c: piix4: Register SPDs
Date: Fri, 12 Jul 2024 14:53:49 +0200	[thread overview]
Message-ID: <ZpEnXaRYnPIr1vG3@shikoro> (raw)
In-Reply-To: <20240709-piix4-spd-v3-2-9d1daa204983@weissschuh.net>

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]


> Only the first 8 slots are supported. If the system has more,
> then these will not be visible.
> 
> The AUX bus can not be probed as on some platforms it reports all
> devices present and all reads return "0".
> This would allow the ee1004 to be probed incorrectly.

I think this information would also be helpful as a comment above the
code. But to allow this series to be applied now, I think an incremental
patch will do. With Heiner's ack, I think this can go in now.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-07-12 12:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09 17:35 [PATCH v3 0/2] i2c: smbus cleanups and SPD support for piix4 Thomas Weißschuh
2024-07-09 17:35 ` [PATCH v3 1/2] i2c: smbus: remove i801 assumptions from SPD probing Thomas Weißschuh
2024-07-09 22:33   ` Andi Shyti
2024-07-12 10:21   ` Heiner Kallweit
2024-07-09 17:35 ` [PATCH v3 2/2] i2c: piix4: Register SPDs Thomas Weißschuh
2024-07-12 12:53   ` Wolfram Sang [this message]
2024-07-16 17:46     ` Andi Shyti
2024-07-16 17:50       ` Thomas Weißschuh
2024-07-16 18:05         ` Andi Shyti
2024-07-12  0:02 ` [PATCH v3 0/2] i2c: smbus cleanups and SPD support for piix4 Andi Shyti
2024-07-12  6:39   ` Wolfram Sang
2024-07-16 18:27 ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZpEnXaRYnPIr1vG3@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=andi.shyti@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=linux@weissschuh.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.