From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from diktynna.open-mesh.org (diktynna.open-mesh.org [136.243.236.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D944C3DA4A for ; Fri, 12 Jul 2024 22:14:06 +0000 (UTC) Received: from diktynna.open-mesh.org (localhost [IPv6:::1]) by diktynna.open-mesh.org (Postfix) with ESMTP id 2C6A7831E5 for ; Sat, 13 Jul 2024 00:14:05 +0200 (CEST) ARC-Seal: i=2; cv=pass; a=rsa-sha256; d=open-mesh.org; s=20121; t=1720822445; b=le63Gq8Y0t1AJ0JSNzs9AnFL8xLWQ3xvEr4mcBbRWwBsFUHDtB3x6cu6El1vB1wHG/HLD jYIDBwCNNicPTpwcobdFGnPvWTkzwWWrYzUthWIYgbX7UNjy/GZpSPw2zbAXYSMBKIf5Osp fLkRhlei6QC4w2xi6hkNQUIFM/nM5ow= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=open-mesh.org; s=20121; t=1720822445; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=2V1KFrs/HSb9wSr30r/z7tXhHMo5H2ISjZA5vIzDtqU=; b=iSklEd/5IGEO48yV0EKKra18s9KdyqzOAiSdnAEQ76IwVbjIt/2orbXBt326dXzsS74vw dvtOGORsNl7VdZvCKKp1mcmR8Jcpmw4ChxC5JhQ8K1EahztiBnuKuaCmgQfta2b8koN8ea8 rDLelLHsSrHy+chGKvGvsHuTD7Yxn2s= ARC-Authentication-Results: i=2; open-mesh.org; dkim=fail; arc=pass; dmarc=none Authentication-Results: open-mesh.org; dkim=fail; arc=pass; dmarc=none Received: from mail.aperture-lab.de (mail.aperture-lab.de [IPv6:2a01:4f8:c2c:665b::1]) by diktynna.open-mesh.org (Postfix) with ESMTPS id 51BCA81B04 for ; Sat, 13 Jul 2024 00:13:56 +0200 (CEST) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=open-mesh.org; s=20121; t=1720822436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2V1KFrs/HSb9wSr30r/z7tXhHMo5H2ISjZA5vIzDtqU=; b=vN+fEzLNXahBRjCz5ukBYqom/s8gugULMXX6hBaQ8+SaxuNnDqxZp3dc/oDt+iTmDlilYa U/ivHtJuy/6T5eS+gunoBqLMMyUbmPikb5oPRk7p78cEfSk3SdDOVI6U+BI2R0I9kWNKHv zKhgulspTKW2Ub1IEQDsqduWxhJ56HU= ARC-Authentication-Results: i=1; diktynna.open-mesh.org; dkim=none; spf=pass (diktynna.open-mesh.org: domain of linus.luessing@c0d3.blue designates 2a01:4f8:c2c:665b::1 as permitted sender) smtp.mailfrom=linus.luessing@c0d3.blue; dmarc=none ARC-Seal: i=1; s=20121; d=open-mesh.org; t=1720822436; a=rsa-sha256; cv=none; b=UhAIumF5lZYiIlj8aVz8gU+GHQKLdm0PqvhoIrKmhfzMV5BZ4cyiOInxFA+jSUs0pnDPBC 7I2NTY5KMrd9YlVhAf68ZuBpmjg45lVZ729aUX3r8RJRuiOhiiY9wxjbPi84DRTd7lqqHA X5jWYRUnS4acCpoZSTF/OU9Rumzw66U= Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 090DE3EE06 for ; Sat, 13 Jul 2024 00:12:07 +0200 (CEST) Date: Sat, 13 Jul 2024 00:13:54 +0200 From: Linus =?utf-8?Q?L=C3=BCssing?= To: b.a.t.m.a.n@lists.open-mesh.org Subject: Re: [PATCH v2] batman-adv: add dynamic, bridged-in TT VID detection support Message-ID: References: <20240612213944.4169-1-linus.luessing@c0d3.blue> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 Message-ID-Hash: W3QFULCF4UT2JEDMO5GTWZ5EPPNPFYX3 X-Message-ID-Hash: W3QFULCF4UT2JEDMO5GTWZ5EPPNPFYX3 X-MailFrom: linus.luessing@c0d3.blue X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-b.a.t.m.a.n.lists.open-mesh.org-0; header-match-b.a.t.m.a.n.lists.open-mesh.org-1; header-match-b.a.t.m.a.n.lists.open-mesh.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: And one more thought/idea that just came to my mind: Maybe after adding dynamic VLAN detection from traffic we could then also exclude the annoying, actually typically unused VID 0 from the static addition? That way we would save quite a bit of overhead as each VLAN currently quite significantly increases the OGM size. So basically thinking of simply adding a "if (!vid) return" to (.ndo_vlan_rx_add_vid =) batadv_interface_add_vid(). One could still use VID 0 on bat0, it just wouldn't be detected as quickly/immediately, would take an actual payload packet to be added. Currently VID 0 is added because we set "dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER" in batadv_softif_init_early(). Which in turn triggers: net/8021q/vlan.c:vlan_device_event()->vlan_vid_add(dev, htons(ETH_P_8021Q), 0) And triggers the message "adding VLAN 0 to HW filter on device bat0" in dmesg. But of course, first the BLA induced 30 seconds broadcast filtering with each added VLAN would need to be solved. As that might be a too easy DoS potential, I guess? Could still need some feedback on how to best solve that (bat_priv->bla.num_requests per VLAN?). Regards, Linus