From: ngn <ngn@ngn.tf>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: shpchp: Remove hpc_ops
Date: Sat, 13 Jul 2024 12:05:32 +0300 [thread overview]
Message-ID: <ZpJDXNtOQWSqG0mi@archbtw> (raw)
In-Reply-To: <20240712224425.GA351076@bhelgaas>
On Fri, Jul 12, 2024 at 05:44:25PM -0500, Bjorn Helgaas wrote:
> On Fri, Jun 21, 2024 at 09:35:00AM +0300, ngn wrote:
> > fix checpatch warnings and call hpc_ops functions directly, this has been
> > also done in pciehp with commit 82a9e79ef132
>
> Trivial changes like checkpatch fixes should be in a separate patch
> from substantive things. This helps make both easier to review.
>
> It *might* be worthwhile to remove hpc_ops, although shpchp is pretty
> old and dusty by now, and it's hard to justify touching things like
> that because the risk of breaking something is relatively high and the
> benefit is relatively low.
>
> The fact that shpchp is the only user of hpc_ops does make me a little
> more sympathetic to the idea of removing it, though.
>
Thanks for the reply! I'll just remove hpc_ops then, and I'll send a separate
patch.
next prev parent reply other threads:[~2024-07-13 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 6:34 [PATCH 0/2] PCI: shpchp: trivial code cleanup patches ngn
2024-06-21 6:35 ` [PATCH 1/2] PCI: shpchp: Remove hpc_ops ngn
2024-07-12 22:44 ` Bjorn Helgaas
2024-07-13 9:05 ` ngn [this message]
2024-06-21 6:35 ` [PATCH 2/2] PCI: shpchp: Follow kernel coding style ngn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpJDXNtOQWSqG0mi@archbtw \
--to=ngn@ngn.tf \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.