From: Breno Leitao <leitao@debian.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: kuba@kernel.org, netdev@vger.kernel.org
Subject: Re: net: bnxt: Crash on 6.10 ioctl
Date: Mon, 15 Jul 2024 04:29:15 -0700 [thread overview]
Message-ID: <ZpUIC2ESlEQP0PP1@gmail.com> (raw)
In-Reply-To: <CACKFLi=Au=9H_O4QtgUJ101NZHAW97DF+isGQ4OOsC3x6O5k0g@mail.gmail.com>
On Fri, Jul 12, 2024 at 10:02:06AM -0700, Michael Chan wrote:
> On Fri, Jul 12, 2024 at 9:03 AM Michael Chan <michael.chan@broadcom.com> wrote:
> >
> > On Fri, Jul 12, 2024 at 7:56 AM Breno Leitao <leitao@debian.org> wrote:
> > > BUG: kernel NULL pointer dereference, address: 00000000000000b8
> > > #PF: supervisor read access in kernel mode
> > > #PF: error_code(0x0000) - not-present page
> > > PGD 0 P4D 0
> > > Oops: Oops: 0000 [#1] SMP
> > > Hardware name: ...
> > > RIP: 0010:bnxt_get_max_rss_ctx_ring (drivers/net/ethernet/broadcom/bnxt/bnxt.c:?)
> >
> > Maybe bp->rss_ctx_list is not valid.
> >
> > I think we can add this check:
> >
> > (bp->rss_cap & BNXT_RSS_CAP_MULTI_RSS_CTX)
> >
> > before proceeding in bnxt_get_max_rss_ctx_ring().
>
> I've confirmed the issue on older NICs not supporting multi RSS
> contexts and I will send out the patch very shortly. Thanks.
Awesome. I've tested it and it fixed the problem.
Thanks!
prev parent reply other threads:[~2024-07-15 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 14:56 net: bnxt: Crash on 6.10 ioctl Breno Leitao
2024-07-12 16:03 ` Michael Chan
2024-07-12 17:02 ` Michael Chan
2024-07-15 11:29 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpUIC2ESlEQP0PP1@gmail.com \
--to=leitao@debian.org \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.