From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: Jason Wang <jasowang@redhat.com>,
Dmitry Fleytman <dmitry.fleytman@gmail.com>,
Sriram Yagnaraman <sriram.yagnaraman@ericsson.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Luigi Rizzo <rizzo@iet.unipi.it>,
Giuseppe Lettieri <g.lettieri@iet.unipi.it>,
Vincenzo Maffione <v.maffione@gmail.com>,
Andrew Melnychenko <andrew@daynix.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 2/5] qdev-properties: Add DEFINE_PROP_ON_OFF_AUTO_BIT64()
Date: Mon, 15 Jul 2024 12:47:57 +0100 [thread overview]
Message-ID: <ZpUMbdszCwd3bFUd@redhat.com> (raw)
In-Reply-To: <20240714-auto-v3-2-e27401aabab3@daynix.com>
On Sun, Jul 14, 2024 at 02:11:02PM +0900, Akihiko Odaki wrote:
> DEFINE_PROP_ON_OFF_AUTO_BIT64() corresponds to DEFINE_PROP_ON_OFF_AUTO()
> as DEFINE_PROP_BIT64() corresponds to DEFINE_PROP_BOOL(). The difference
> is that DEFINE_PROP_ON_OFF_AUTO_BIT64() exposes OnOffAuto instead of
> bool.
IMHO this shouldn't be implemented in terms of On/Off auto,
as it is misleadingly accepting much more than PROP_ON_OFF
accepts. Rather it should be just DEFINE_PROP_AUTO_BIT64,
implemented in terms of 'bool', with an extra 'auto' value.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-07-15 11:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-14 5:11 [PATCH v3 0/5] virtio-net: Convert feature properties to OnOffAuto Akihiko Odaki
2024-07-14 5:11 ` [PATCH v3 1/5] qdev-properties: Accept bool for OnOffAuto Akihiko Odaki
2024-07-15 11:38 ` Daniel P. Berrangé
2024-07-16 6:11 ` Akihiko Odaki
2024-07-14 5:11 ` [PATCH v3 2/5] qdev-properties: Add DEFINE_PROP_ON_OFF_AUTO_BIT64() Akihiko Odaki
2024-07-15 11:47 ` Daniel P. Berrangé [this message]
2024-07-16 6:23 ` Akihiko Odaki
2024-07-14 5:11 ` [PATCH v3 3/5] virtio-net: Convert feature properties to OnOffAuto Akihiko Odaki
2024-07-14 5:11 ` [PATCH v3 4/5] virtio-net: Report RSS warning at device realization Akihiko Odaki
2024-07-14 5:11 ` [PATCH v3 5/5] virtio-net: Remove fallback from ebpf-rss-fds Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpUMbdszCwd3bFUd@redhat.com \
--to=berrange@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=andrew@daynix.com \
--cc=dmitry.fleytman@gmail.com \
--cc=eduardo@habkost.net \
--cc=g.lettieri@iet.unipi.it \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
--cc=sriram.yagnaraman@ericsson.com \
--cc=v.maffione@gmail.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.