From: Brian Norris <briannorris@chromium.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Francesco Dolcini <francesco@dolcini.it>,
Kalle Valo <kvalo@kernel.org>, David Lin <yu-hao.lin@nxp.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] wifi: mwifiex: fix key_mgmt setting
Date: Tue, 23 Jul 2024 10:10:12 -0700 [thread overview]
Message-ID: <Zp_j9P6jTzMpCqO-@google.com> (raw)
In-Reply-To: <20240723-mwifiex-wpa-psk-sha256-v3-2-025168a91da1@pengutronix.de>
On Tue, Jul 23, 2024 at 09:09:58AM +0200, Sascha Hauer wrote:
> bss_config->key_mgmt specifies the AKM suites that are usable in
> hardware. This variable is set to specific values while iterating
> over the advertised AKM suites. This means the final value of the
> variable depends on the order of the entries in the AKM suites
> array. Instead of setting the variable, just set the relevant bits
> in the key_mgmt bit field to make us independent of the order of
> entries.
> This behaviour is derived from the downstream driver that does the
> same.
> Also, set bss_config->key_mgmt to zero explicitly right before the
> loop. bss_config has been zero allocated by the caller already, but
> do so again to safe the reader from following the code path.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/net/wireless/marvell/mwifiex/uap_cmd.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Acked-by: Brian Norris <briannorris@chromium.org>
next prev parent reply other threads:[~2024-07-23 17:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 7:09 [PATCH v3 0/3] mwifiex: add support for WPA-PSK-SHA256 Sascha Hauer
2024-07-23 7:09 ` [PATCH v3 1/3] wifi: mwifiex: simplify WPA flags setting Sascha Hauer
2024-08-04 8:57 ` Kalle Valo
2024-08-05 7:36 ` Sascha Hauer
2024-07-23 7:09 ` [PATCH v3 2/3] wifi: mwifiex: fix key_mgmt setting Sascha Hauer
2024-07-23 7:52 ` Francesco Dolcini
2024-07-23 17:10 ` Brian Norris [this message]
2024-07-23 7:09 ` [PATCH v3 3/3] wifi: mwifiex: add support for WPA-PSK-SHA256 Sascha Hauer
2024-07-23 17:10 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zp_j9P6jTzMpCqO-@google.com \
--to=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=yu-hao.lin@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.