From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5121C1C6B7 for ; Tue, 16 Jul 2024 18:26:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721154385; cv=none; b=EQbElx7KsIi1EVmJr+p6AIzG5XLkmSrkI0cu8FQqdurds/A+PT00pFRVnfy40lD1fg1VVROPy39x2HQr/11U1ZMWfc9bmELrf+Q7T4ChGcvrehZBEGl2LFwRhJKQ6ifbHEln+oaIVneZrkCuD3QViBy71RnlJOGnShNZEUy/sDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721154385; c=relaxed/simple; bh=j01aD+nuAVH3d1VVBo4MhqZQFEQ01MiGV1ti6HHpf2I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=W0lcwfv22UYLVRliHWqZd/3w2alnavhcGmWhQalnWj6HULQXphLzZTAXhVZDSvx3DK4R6yMqcBjEZ/JwUcqdnnKBu3nHWqD4lH9wIO7u9KG2GvXl+lK3sZpQm6BmXxbQBOdebLFY1HUC3Rix6mjCStXT29OSR8L+KtMJ99ODM0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IAN0eCcL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IAN0eCcL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721154383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/AfWmax8nn58pfrGQjtZUSoIWAJwuBLlhV39szjT1Vg=; b=IAN0eCcLqZ0wCeUIk3bM0TXsThNE/XHIZciK3rHy1V25JirQ2/JlAROhU5xsrlybc7bbX+ ALQYEhQjW5HtR5OBA7L+utIWgXSjrIrf59M7EI8r4Wae4FP/cZv5NTx52qdl9GTWipXHlU hsrrc4EOqPhj04f/VPJogRZ0i5UdjEA= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-tZz8x5RaMjem9_o8c5LUoQ-1; Tue, 16 Jul 2024 14:26:20 -0400 X-MC-Unique: tZz8x5RaMjem9_o8c5LUoQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E40A1195609F; Tue, 16 Jul 2024 18:26:18 +0000 (UTC) Received: from bmarzins-01.fast.eng.rdu2.dc.redhat.com (bmarzins-01.fast.eng.rdu2.dc.redhat.com [10.6.23.12]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8E4971955D45; Tue, 16 Jul 2024 18:26:18 +0000 (UTC) Received: from bmarzins-01.fast.eng.rdu2.dc.redhat.com (localhost [127.0.0.1]) by bmarzins-01.fast.eng.rdu2.dc.redhat.com (8.17.2/8.17.1) with ESMTPS id 46GIQHwj2126741 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 16 Jul 2024 14:26:17 -0400 Received: (from bmarzins@localhost) by bmarzins-01.fast.eng.rdu2.dc.redhat.com (8.17.2/8.17.2/Submit) id 46GIQHn12126740; Tue, 16 Jul 2024 14:26:17 -0400 Date: Tue, 16 Jul 2024 14:26:17 -0400 From: Benjamin Marzinski To: Martin Wilck Cc: Christophe Varoqui , device-mapper development Subject: Re: [PATCH 19/22] multipathd: make multipath devices manage their path check times Message-ID: References: <20240713060506.2015463-1-bmarzins@redhat.com> <20240713060506.2015463-20-bmarzins@redhat.com> Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 16, 2024 at 06:36:35PM +0200, Martin Wilck wrote: > On Mon, 2024-07-15 at 22:49 +0200, Martin Wilck wrote: > > On Sat, 2024-07-13 at 02:05 -0400, Benjamin Marzinski wrote: > > > + next_idx = (start_secs + pp->tick) % adjust_int; > > > + if (next_idx > goal_idx && next_idx - goal_idx < pp- > > > > checkint) > > > + pp->tick--; > > This code raises compilation errors on some architectures, see > https://github.com/openSUSE/multipath-tools/actions/runs/9942603306/job/27464440204 > > Martin Thanks. Switching to your modulo idea for checking offset will avoid this. -Ben