From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: John Stultz <jstultz@google.com>, ltp@lists.linux.it
Subject: Re: [LTP] [RFC PATCH 2/2] sched_football: Rewrite into new API
Date: Wed, 17 Jul 2024 16:52:26 +0200 [thread overview]
Message-ID: <ZpfaqobEpwqoDDE9@rei> (raw)
In-Reply-To: <20240711104400.63355-2-pvorel@suse.cz>
Hi!
> -/* Here's the position of the ball */
> -static int the_ball;
> -
> +static int ball;
Honestly the only thing that I do not like about this is that you
dropped the the_ from the ball, because *the* ball is *the* thing that
we observe for the whole time.
Otherwise I do not think that the test library can interfere with the
test in any way so we can go ahead and push this.
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-07-17 14:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 10:43 [LTP] [RFC PATCH 1/2] realtime: Use offsetof() macro from <stddef.h> Petr Vorel
2024-07-11 10:43 ` [LTP] [RFC PATCH 2/2] sched_football: Rewrite into new API Petr Vorel
2024-07-12 11:21 ` Cyril Hrubis
2024-07-12 13:22 ` Petr Vorel
2024-07-12 14:11 ` Cyril Hrubis
2024-07-12 19:09 ` Petr Vorel
2024-07-15 9:07 ` Cyril Hrubis
2024-07-15 9:52 ` Petr Vorel
2024-07-15 10:38 ` Cyril Hrubis
2024-07-15 12:44 ` Petr Vorel
2024-07-17 14:52 ` Cyril Hrubis [this message]
2024-07-17 16:03 ` Petr Vorel
2024-07-12 9:57 ` [LTP] [RFC PATCH 1/2] realtime: Use offsetof() macro from <stddef.h> Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpfaqobEpwqoDDE9@rei \
--to=chrubis@suse.cz \
--cc=jstultz@google.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.