From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] sparse: ignore warning from new glibc headers
Date: Thu, 18 Jul 2024 09:39:44 +0700 [thread overview]
Message-ID: <ZpiAcJuAH50UlHIX@danh.dev> (raw)
In-Reply-To: <a1a771b5-f8fb-40e3-bae0-6307abbce58a@ramsayjones.plus.com>
On 2024-07-18 01:02:54+0100, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
>
>
> On 17/07/2024 23:53, Junio C Hamano wrote:
> [snip]
> > That's OK. So in short, with a separate SP_EXTRA_FLAGS with "-Wno-vla",
> > Luc's patch is a sufficient fix without any downsides, no?
> >
>
> Yes, assuming you're only concerned with 'make sparse' usage.
>
> BTW, I didn't expect it to take this long for this issue to come
> back to the list! I expected it to almost immediately cause
> problems with the sparse ci job, when the version of Ubuntu was
> updated to the LTS (now previous LTS!). So, I just found a simple
> solution for now (which turned into 2 years).
Well, yeah, -Wno-vla would work, I used that macro __STDC_NO_VLA__
because I'm not sure Git want to use vla or not, so I only tried to
disable it for system headers.
And yes, the vla declarationw as added into glibc 2.35.
--
Danh
next prev parent reply other threads:[~2024-07-18 2:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 23:17 [PATCH] sparse: ignore warning from new glibc headers Đoàn Trần Công Danh
2024-07-17 16:54 ` Junio C Hamano
2024-07-17 18:40 ` Ramsay Jones
2024-07-17 18:51 ` Junio C Hamano
2024-07-17 19:20 ` Ramsay Jones
2024-07-17 22:36 ` Ramsay Jones
2024-07-17 22:53 ` Junio C Hamano
2024-07-18 0:02 ` Ramsay Jones
2024-07-18 2:39 ` Đoàn Trần Công Danh [this message]
2024-07-18 7:07 ` Junio C Hamano
2024-07-18 8:46 ` Đoàn Trần Công Danh
2024-07-18 4:47 ` Junio C Hamano
2024-07-19 2:03 ` Ramsay Jones
2025-04-08 20:56 ` Johannes Schindelin
2025-04-08 22:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpiAcJuAH50UlHIX@danh.dev \
--to=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.