From: Brian Norris <briannorris@chromium.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Francesco Dolcini <francesco@dolcini.it>,
Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] wifi: mwifiex: simplify WPA flags setting
Date: Thu, 18 Jul 2024 15:40:22 -0700 [thread overview]
Message-ID: <ZpmZ1hXWPRCpUaUt@google.com> (raw)
In-Reply-To: <20240717-mwifiex-wpa-psk-sha256-v2-1-eb53d5082b62@pengutronix.de>
On Wed, Jul 17, 2024 at 10:30:07AM +0200, Sascha Hauer wrote:
> The WPA flags setting only depends on the wpa_versions bitfield and not
> on the AKM suite, so move it out of the switch/case to simplify the code
> a bit. Also set bss_config->protocol to zero explicitly. This is done
> only to make the code clearer, bss_config has been zero alloced by the
> caller, so should be zero already. No functional change intended.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/net/wireless/marvell/mwifiex/uap_cmd.c | 28 ++++++++------------------
> 1 file changed, 8 insertions(+), 20 deletions(-)
Acked-by: Brian Norris <briannorris@chromium.org>
next prev parent reply other threads:[~2024-07-18 22:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 8:30 [PATCH v2 0/2] mwifiex: add support for WPA-PSK-SHA256 Sascha Hauer
2024-07-17 8:30 ` [PATCH v2 1/2] wifi: mwifiex: simplify WPA flags setting Sascha Hauer
2024-07-17 8:40 ` Francesco Dolcini
2024-07-18 22:40 ` Brian Norris [this message]
2024-07-17 8:30 ` [PATCH v2 2/2] wifi: mwifiex: add support for WPA-PSK-SHA256 Sascha Hauer
2024-07-18 22:55 ` Brian Norris
2024-07-19 6:04 ` Sascha Hauer
2024-07-19 19:05 ` Brian Norris
2024-07-22 7:48 ` Sascha Hauer
2024-07-22 8:46 ` [EXT] " David Lin
2024-07-22 19:30 ` Brian Norris
2024-07-23 7:04 ` Sascha Hauer
2024-07-22 10:57 ` Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpmZ1hXWPRCpUaUt@google.com \
--to=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.