From: Imre Deak <imre.deak@intel.com>
To: Jocelyn Falempe <jfalempe@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Javier Martinez Canillas <javierm@redhat.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panic: Add missing static inline to drm_panic_is_enabled()
Date: Fri, 19 Jul 2024 14:39:05 +0300 [thread overview]
Message-ID: <ZppQWb05llyndFh-@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20240719103615.1489714-1-jfalempe@redhat.com>
On Fri, Jul 19, 2024 at 12:36:08PM +0200, Jocelyn Falempe wrote:
> This breaks build if DRM_PANIC is not enabled.
>
> Fixes: de338c754d40 ("drm/panic: Add missing static inline to drm_panic_is_enabled()")
> Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
Thanks for the quick fix:
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/drm_crtc_internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h
> index c10de39cbe83..bbac5350774e 100644
> --- a/drivers/gpu/drm/drm_crtc_internal.h
> +++ b/drivers/gpu/drm/drm_crtc_internal.h
> @@ -321,7 +321,7 @@ drm_edid_load_firmware(struct drm_connector *connector)
> #ifdef CONFIG_DRM_PANIC
> bool drm_panic_is_enabled(struct drm_device *dev);
> #else
> -bool drm_panic_is_enabled(struct drm_device *dev) {return false; }
> +static inline bool drm_panic_is_enabled(struct drm_device *dev) {return false; }
> #endif
>
> #endif /* __DRM_CRTC_INTERNAL_H__ */
> --
> 2.45.2
>
next prev parent reply other threads:[~2024-07-19 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 10:36 [PATCH] drm/panic: Add missing static inline to drm_panic_is_enabled() Jocelyn Falempe
2024-07-19 11:39 ` Imre Deak [this message]
2024-07-19 11:43 ` Imre Deak
2024-07-19 12:01 ` Imre Deak
2024-07-19 12:17 ` Jocelyn Falempe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZppQWb05llyndFh-@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jfalempe@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.