From: "J. Neuschäfer via buildroot" <buildroot@buildroot.org>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
"J. Neuschäfer" <j.neuschaefer@gmx.net>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v4] Config.in: ban textrels on musl toolchains
Date: Fri, 19 Jul 2024 15:43:42 +0200 [thread overview]
Message-ID: <Zpptjqx6nQD2XetS@probook> (raw)
In-Reply-To: <08cd73a1-8e7c-4891-b3c8-84fba092877d@mind.be>
On Fri, Jul 19, 2024 at 09:19:22AM +0200, Arnout Vandecappelle wrote:
> On 19/07/2024 08:49, J. Neuschäfer wrote:
> > On Thu, Jul 18, 2024 at 10:33:23PM +0200, J. Neuschäfer wrote:
> > > +ifeq ($(BR2_TOOLCHAIN_USES_MUSL)$(BR2_BINFMT_SUPPORTS_SHARED),yy)
> >
> > I just noticed that BR2_BINFMT_SUPPORTS_SHARED is incorrect, because
> > it's true regardless of whether shared libraries are actually used.
> > What I was aiming for is "BR2_SHARED_LIBS or BR2_SHARED_STATIC_LIBS".
> >
> > I suppose this should work:
> >
> > ifeq ($(BR2_TOOLCHAIN_USES_MUSL)$(BR2_SHARED_LIBS)$(BR2_SHARED_STATIC_LIBS),yy)
>
> What we do is:
>
> ifeq ($(BR2_TOOLCHAIN_USES_MUSL):$(BR2_STATIC_LIBS),y:)
>
> This says that musl must be y and static must not be.
Nice trick, I'll use it.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-07-19 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 20:33 [Buildroot] [PATCH v4] Config.in: ban textrels on musl toolchains J. Neuschäfer via buildroot
2024-07-19 6:49 ` J. Neuschäfer via buildroot
2024-07-19 7:19 ` Arnout Vandecappelle via buildroot
2024-07-19 13:43 ` J. Neuschäfer via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zpptjqx6nQD2XetS@probook \
--to=buildroot@buildroot.org \
--cc=arnout@mind.be \
--cc=j.neuschaefer@gmx.net \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.