From: Drew Fustini <drew@pdp7.com>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: sboyd@kernel.org, mturquette@baylibre.com, jszhang@kernel.org,
dfustini@tenstorrent.com, frank.li@vivo.com,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: T-Head: Disable on 32-bit Targets
Date: Sat, 20 Jul 2024 10:38:14 -0700 [thread overview]
Message-ID: <Zpv2Btw3dUXaJxp9@x1> (raw)
In-Reply-To: <20240719151027.16152-1-palmer@rivosinc.com>
On Fri, Jul 19, 2024 at 08:10:27AM -0700, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmer@rivosinc.com>
>
> This fails to build on 32-bit targets because of a missing __udivdi3.
> IIRC the right way to fix that is to avoid the division, but I just want
> a tree that builds and the only real T-Head platforms are 64-bit right
> now.
>
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
> drivers/clk/thead/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/thead/Kconfig b/drivers/clk/thead/Kconfig
> index 1710d50bf9d4..95e0d9eb965e 100644
> --- a/drivers/clk/thead/Kconfig
> +++ b/drivers/clk/thead/Kconfig
> @@ -3,6 +3,7 @@
> config CLK_THEAD_TH1520_AP
> bool "T-HEAD TH1520 AP clock support"
> depends on ARCH_THEAD || COMPILE_TEST
> + depends on 64BIT
> default ARCH_THEAD
> select REGMAP_MMIO
> help
> --
> 2.45.2
>
Acked-by: Drew Fustini <drew@pdp7.com>
Sorry about that. This patch makes sense as the TH1520 SoC is 64-bit
and I see no valid use case to run a 32-bit kernel on it.
Drew
next prev parent reply other threads:[~2024-07-20 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 15:10 [PATCH] clk: T-Head: Disable on 32-bit Targets Palmer Dabbelt
2024-07-20 17:38 ` Drew Fustini [this message]
2024-07-22 21:29 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zpv2Btw3dUXaJxp9@x1 \
--to=drew@pdp7.com \
--cc=dfustini@tenstorrent.com \
--cc=frank.li@vivo.com \
--cc=jszhang@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=palmer@rivosinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.