From: Carlos Llamas <cmllamas@google.com>
To: Veerendranath Jakkam <quic_vjakkam@quicinc.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] wifi: cfg80211: fix reporting failed MLO links status with cfg80211_connect_done
Date: Wed, 24 Jul 2024 13:40:24 +0000 [thread overview]
Message-ID: <ZqED64mn7pIHsl1n@google.com> (raw)
In-Reply-To: <20240724125327.3495874-1-quic_vjakkam@quicinc.com>
On Wed, Jul 24, 2024 at 06:23:27PM +0530, Veerendranath Jakkam wrote:
> Individual MLO links connection status not copied to
> EVENT_CONNECT_RESULT data while processing the connect response
> information in cfg80211_connect_done(). Due to this failed links also
> indicated with success status in EVENT_CONNECT_RESULT.
>
> To fix this, copy the individual MLO links status to
> EVENT_CONNECT_RESULT data.
>
> Fixes: 53ad07e9823b ("wifi: cfg80211: support reporting failed links")
> Signed-off-by: Veerendranath Jakkam <quic_vjakkam@quicinc.com>
> ---
> v2:
> - Add "Fixes:" tag in commit text.
> ---
> net/wireless/sme.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
> index e419aa8c4a5a..d9d7bf8bb5c1 100644
> --- a/net/wireless/sme.c
> +++ b/net/wireless/sme.c
> @@ -1045,6 +1045,7 @@ void cfg80211_connect_done(struct net_device *dev,
> cfg80211_hold_bss(
> bss_from_pub(params->links[link].bss));
> ev->cr.links[link].bss = params->links[link].bss;
> + ev->cr.links[link].status = params->links[link].status;
>
> if (params->links[link].addr) {
> ev->cr.links[link].addr = next;
> --
> 2.34.1
>
LGTM,
Reviewed-by: Carlos Llamas <cmllamas@google.com>
prev parent reply other threads:[~2024-07-24 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 12:53 [PATCH v2] wifi: cfg80211: fix reporting failed MLO links status with cfg80211_connect_done Veerendranath Jakkam
2024-07-24 13:40 ` Carlos Llamas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqED64mn7pIHsl1n@google.com \
--to=cmllamas@google.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_vjakkam@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.