From: Roman Gushchin <roman.gushchin@linux.dev>
To: Kinsey Ho <kinseyho@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Yosry Ahmed <yosryahmed@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>
Subject: Re: [PATCH mm-unstable v1 0/4] Improve mem_cgroup_iter()
Date: Thu, 25 Jul 2024 00:25:16 +0000 [thread overview]
Message-ID: <ZqGbbN2Ue8HLlVmL@google.com> (raw)
In-Reply-To: <20240724190214.1108049-1-kinseyho@google.com>
cc memcg maintainers
On Wed, Jul 24, 2024 at 07:02:10PM +0000, Kinsey Ho wrote:
> Incremental cgroup iteration is being used again [1], but incremental
> cgroup iteration was introduced for cgroup v1. It hasn't been fully
> maintained for many years.
This is a bold statement :)
> This patchset improves the reliability of
> mem_cgroup_iter(), along with improving simplicity and code readability.
>
> [1] https://lore.kernel.org/20240514202641.2821494-1-hannes@cmpxchg.org/
>
> Kinsey Ho (4):
> mm: don't hold css->refcnt during traversal
> mm: increment gen # before restarting traversal
> mm: restart if multiple traversals raced
> mm: clean up mem_cgroup_iter()
But the series looks great to me!
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
for the series.
Thanks!
prev parent reply other threads:[~2024-07-25 0:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 19:02 [PATCH mm-unstable v1 0/4] Improve mem_cgroup_iter() Kinsey Ho
2024-07-24 19:02 ` [PATCH mm-unstable v1 1/4] mm: don't hold css->refcnt during traversal Kinsey Ho
2024-07-25 16:33 ` kernel test robot
2024-07-25 20:43 ` Johannes Weiner
2024-07-25 21:09 ` Roman Gushchin
2024-07-25 22:33 ` Yosry Ahmed
2024-08-01 21:46 ` Kinsey Ho
2024-08-01 22:32 ` Kinsey Ho
2024-08-02 1:28 ` Johannes Weiner
2024-07-24 19:02 ` [PATCH mm-unstable v1 2/4] mm: increment gen # before restarting traversal Kinsey Ho
2024-07-25 20:53 ` Johannes Weiner
2024-07-24 19:02 ` [PATCH mm-unstable v1 3/4] mm: restart if multiple traversals raced Kinsey Ho
2024-07-24 19:02 ` [PATCH mm-unstable v1 4/4] mm: clean up mem_cgroup_iter() Kinsey Ho
2024-07-25 18:15 ` kernel test robot
2024-07-25 0:25 ` Roman Gushchin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqGbbN2Ue8HLlVmL@google.com \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kinseyho@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.