All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylvain BERTRAND <sylvain.bertrand@legeek.net>
To: alsa-devel@alsa-project.org
Subject: [PATCH][LINUX][ALSA][USB AUDIO CLASS 1] wrong channel ids for surround
Date: Thu, 25 Jul 2024 11:08:20 +0000	[thread overview]
Message-ID: <ZqIyJD8lhd8hFhlC@freedom> (raw)

Hi,

In the USB audio class 1 specifications, page 33 (3.7.2.3 Audio Channel Cluster Format):

Surround is spatially defined as [rear], hence left surround should be SNDRV_CHMAP_RL and not SND_CHMAP_SL (Side).
Same for right surround channel.

Right?

I am not a mailing list subscriber, CC me please.

regards,

-- 
Sylvain BERTRAND


--- a/sound/usb/stream.c
+++ b/sound/usb/stream.c
@@ -244,8 +244,8 @@ static struct snd_pcm_chmap_elem *convert_chmap(int channels, unsigned int bits,
 		SNDRV_CHMAP_FR,		/* right front */
 		SNDRV_CHMAP_FC,		/* center front */
 		SNDRV_CHMAP_LFE,	/* LFE */
-		SNDRV_CHMAP_SL,		/* left surround */
-		SNDRV_CHMAP_SR,		/* right surround */
+		SNDRV_CHMAP_RL,		/* left surround */
+		SNDRV_CHMAP_RR,		/* right surround */
 		SNDRV_CHMAP_FLC,	/* left of center */
 		SNDRV_CHMAP_FRC,	/* right of center */
 		SNDRV_CHMAP_RC,		/* surround */


             reply	other threads:[~2024-07-31  8:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25 11:08 Sylvain BERTRAND [this message]
2024-07-31  9:26 ` [PATCH][LINUX][ALSA][USB AUDIO CLASS 1] wrong channel ids for surround Takashi Iwai
2024-07-31 14:06   ` Sylvain BERTRAND
2024-07-31 14:19     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZqIyJD8lhd8hFhlC@freedom \
    --to=sylvain.bertrand@legeek.net \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.