Re: [net PATCH] fbnic: Change kconfig prompt from S390=n to !S390

[Joe Damato <jdamato@fastly.com>]

On Thu, Jul 25, 2024 at 10:03:54AM -0700, Alexander Duyck wrote:
> From: Alexander Duyck <alexanderduyck@fb.com>
> 
> In testing the recent kernel I found that the fbnic driver couldn't be
> enabled on x86_64 builds. A bit of digging showed that the fbnic driver was
> the only one to check for S390 to be n, all others had checked for !S390.
> Since it is a boolean and not a tristate I am not sure it will be N. So
> just update it to use the !S390 flag.
> 
> A quick check via "make menuconfig" verified that after making this change
> there was an option to select the fbnic driver.
> 
> Signed-off-by: Alexander Duyck <alexanderduyck@fb.com>

[...]

This seems fine to me (and matches other drivers as you mentioned),
but does it need:

Fixes 0e03c643dc93 ("eth: fbnic: fix s390 build.") 

for it be applied to net?

In either case:

Reviewed-by: Joe Damato <jdamato@fastly.com>