From: Stanislav Fomichev <sdf@fomichev.me>
To: Rao Shoaib <rao.shoaib@oracle.com>
Cc: sdf@google.com, Eric Dumazet <edumazet@google.com>,
priyarjha@google.com, ycheng@google.com, soheil@google.com,
daniel@iogearbox.net, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: bpf: add BPF_CGROUP_SOCK_OPS callback that is executed on every RTT (commit: 23729ff23186424)
Date: Thu, 25 Jul 2024 20:29:49 -0700 [thread overview]
Message-ID: <ZqMYLWFWEC0OWjrl@mini-arch> (raw)
In-Reply-To: <2628656e-ea6f-4885-8fbc-bd14f07a5b00@oracle.com>
On 07/25, Rao Shoaib wrote:
> Hi Stanislav,
>
> I have a question about the placement of tcp_bpf_rtt() call in
> tcp_rtt_estimator(). Why is the call made before the assignment
>
> tp->srtt_us = max(1U, srtt);
>
> How is the attached eBPF program suppose the get the new value?
Take a look at the way tcp_bpf_rtt is invoked. It gets mrtt_us
and srtt arguments. Those are passed via bpf_sock_ops args field.
See tools/testing/selftests/bpf/progs/tcp_rtt.c. Hope that helps!
prev parent reply other threads:[~2024-07-26 3:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 19:37 bpf: add BPF_CGROUP_SOCK_OPS callback that is executed on every RTT (commit: 23729ff23186424) Rao Shoaib
2024-07-26 3:29 ` Stanislav Fomichev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqMYLWFWEC0OWjrl@mini-arch \
--to=sdf@fomichev.me \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=priyarjha@google.com \
--cc=rao.shoaib@oracle.com \
--cc=sdf@google.com \
--cc=soheil@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.