Re: [Buildroot] [PATCH 1/1] package/tipidee: fix uclibc build

["J. Neuschäfer via buildroot" <buildroot@buildroot.org>]

On Wed, Jul 24, 2024 at 01:55:54PM +0200, Fabrice Fontaine wrote:
> Set _GNU_SOURCE in CFLAGS to fix the following uclibc build failure
> raised since the addition of the package in commit
> 17deaf60f66fc08a796233920a104e5233b501e0:
>
> src/libtipidee/tipidee_response_header_lastmodified.c: In function 'tipidee_response_header_lastmodified':
> src/libtipidee/tipidee_response_header_lastmodified.c:17:36: error: 'const struct stat' has no member named 'st_mtim'; did you mean 'st_mtime'?
>    17 |   if (!tain_from_timespec(&t, &st->st_mtim)) return 0 ;
>       |                                    ^~~~~~~
>       |                                    st_mtime
>
> Fixes: 17deaf60f66fc08a796233920a104e5233b501e0
>  - http://autobuild.buildroot.org/results/f07d6d6ae2331f9972974093c0503b9d3c6b914a
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/tipidee/tipidee.mk | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/package/tipidee/tipidee.mk b/package/tipidee/tipidee.mk
> index 915b4f84bd..cb33b153e6 100644
> --- a/package/tipidee/tipidee.mk
> +++ b/package/tipidee/tipidee.mk
> @@ -11,6 +11,7 @@ TIPIDEE_LICENSE_FILES = COPYING
>  TIPIDEE_DEPENDENCIES = skalibs
>
>  TIPIDEE_CONF_OPTS = \
> +	CFLAGS="$(TARGET_CFLAGS) -D_GNU_SOURCE" \

This seems fine as a stop-gap solution, but since upstream documents
that it only needs "A POSIX-compliant system with a standard C
development environment", have you discussed this issue with the
upstream author?


Best regards,
-- jn
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot