From: Mike Rapoport <rppt@kernel.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/5] memblock test: fix implicit declaration of function 'virt_to_phys'
Date: Sun, 28 Jul 2024 08:56:26 +0300 [thread overview]
Message-ID: <ZqXdigYmtS27MxV4@kernel.org> (raw)
In-Reply-To: <20240725014157.17707-1-richard.weiyang@gmail.com>
On Thu, Jul 25, 2024 at 01:41:53AM +0000, Wei Yang wrote:
> Commit 94ff46de4a73 ("memblock: Move late alloc warning down to phys
> alloc") introduce the usage of virt_to_phys(), which is not defined in
> memblock tests.
>
> Define it in kernel.h to fix the build error.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> ---
> tools/testing/memblock/linux/kernel.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/memblock/linux/kernel.h b/tools/testing/memblock/linux/kernel.h
> index d2f148bd8902..ca56f36ef296 100644
> --- a/tools/testing/memblock/linux/kernel.h
> +++ b/tools/testing/memblock/linux/kernel.h
> @@ -9,4 +9,6 @@
> #include <linux/linkage.h>
> #include <linux/kconfig.h>
>
> +#define virt_to_phys(p) ((unsigned long)p)
> +
There's already phys_to_virt() in tools/include/linux/mm.h.
It'd be better to put this one next to it.
> #endif
> --
> 2.34.1
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2024-07-28 5:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 1:41 [PATCH 1/5] memblock test: fix implicit declaration of function 'virt_to_phys' Wei Yang
2024-07-25 1:41 ` [PATCH 2/5] memblock test: add the definition of __setup() Wei Yang
2024-07-25 1:41 ` [PATCH 3/5] memblock test: fix implicit declaration of function 'memparse' Wei Yang
2024-07-25 1:41 ` [PATCH 4/5] memblock test: fix implicit declaration of function 'isspace' Wei Yang
2024-07-28 5:58 ` Mike Rapoport
2024-07-25 1:41 ` [PATCH 5/5] memblock test: fix implicit declaration of function 'strscpy' Wei Yang
2024-07-28 5:56 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqXdigYmtS27MxV4@kernel.org \
--to=rppt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.