Re: [Buildroot] [PATCH 1/1] package/libcamera-apps: bump to version 1.5.0

From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libcamera-apps: bump to version 1.5.0
Date: Mon, 29 Jul 2024 09:07:33 +0200	[thread overview]
Message-ID: <Zqc_tZukfxHNkgvN@gmail.com> (raw)
In-Reply-To: <20240723171435.1231918-1-fontaine.fabrice@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1562 bytes --]

Hi Fabrice,

On Tue, Jul 23, 2024 at 07:14:35PM +0200, Fabrice Fontaine wrote:
> - Use official tarball
> - Switch to meson-package
> - libcamera-apps unconditionally uses linux/dma-heap.h since version
>   1.3.0 and
>   https://github.com/raspberrypi/rpicam-apps/commit/11338687635cc5564c348c2f60c8c58c5779151d
>   which is only available since kernel >= 5.5 and
>   https://github.com/torvalds/linux/commit/a69b0e855d3fd278ff6f09a23e1edf929538e304
> - This bump will fix the following build failure raised since bump of
>   libcamera to version 0.3.0 in commit
>   82efc2faa923e8881748738963be1fbe3cb2bb45:
> 
> /workdir/instance-1/output-1/build/libcamera-apps-1.2.1/core/libcamera_app.cpp: In member function 'void LibcameraApp::ConfigureViewfinder()':
> /workdir/instance-1/output-1/build/libcamera-apps-1.2.1/core/libcamera_app.cpp:327:25: error: 'class libcamera::CameraConfiguration' has no member named 'transform'
>   327 |         configuration_->transform = options_->transform;
>       |                         ^~~~~~~~~
> 
> It shall be noted that upstream changed its name from libcamera-apps to
> rpicam-apps perhaps the package shall also be renamed on buildroot side
> 
> Fixes: 82efc2faa923e8881748738963be1fbe3cb2bb45
>  - http://autobuild.buildroot.org/results/18bb6d9c88c1a813a350658b251293744e161916
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---

Unfortunately, I've currently no setup to test it, but the patch is LGTM.

Reviewed-by: Marcus Folkesson <marcus.folkesson@gmail.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot