From: Sean Christopherson <seanjc@google.com>
To: Kai Huang <kai.huang@intel.com>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"flyingpenghao@gmail.com" <flyingpenghao@gmail.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"flyingpeng@tencent.com" <flyingpeng@tencent.com>
Subject: Re: [PATCH] KVM: X86: Remove unnecessary GFP_KERNEL_ACCOUNT for temporary variables
Date: Mon, 29 Jul 2024 08:31:03 -0700 [thread overview]
Message-ID: <Zqe1t_tc8LWNv39J@google.com> (raw)
In-Reply-To: <b999afeb588eb75d990891855bc6d58861968f23.camel@intel.com>
On Sat, Jun 29, 2024, Kai Huang wrote:
> On Fri, 2024-06-28 at 15:55 -0700, Sean Christopherson wrote:
> > On Mon, 24 Jun 2024 09:20:16 +0800, flyingpenghao@gmail.com wrote:
> > > Some variables allocated in kvm_arch_vcpu_ioctl are released when
> > > the function exits, so there is no need to set GFP_KERNEL_ACCOUNT.
> >
> > Applied to kvm-x86 misc, thanks!
> >
> > [1/1] KVM: X86: Remove unnecessary GFP_KERNEL_ACCOUNT for temporary variables
> > https://github.com/kvm-x86/linux/commit/dd103407ca31
> >
> > --
> > https://github.com/kvm-x86/linux/tree/next
> >
>
> Hi Sean,
Sorry, lost this at the bottom of my inbox.
> I thought we should use _ACCOUNT even for temporary variables.
Heh, that's what I thought too.
[*] https://lore.kernel.org/all/c0122f66-f428-417e-a360-b25fc0f154a0@p183
next prev parent reply other threads:[~2024-07-29 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 1:20 [PATCH] KVM: X86: Remove unnecessary GFP_KERNEL_ACCOUNT for temporary variables flyingpenghao
2024-06-28 22:55 ` Sean Christopherson
2024-06-29 2:41 ` Huang, Kai
2024-07-29 15:31 ` Sean Christopherson [this message]
2024-07-30 0:51 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zqe1t_tc8LWNv39J@google.com \
--to=seanjc@google.com \
--cc=flyingpeng@tencent.com \
--cc=flyingpenghao@gmail.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.