From: Danilo Krummrich <dakr@redhat.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: dri-devel@lists.freedesktop.org, Ben Skeggs <bskeggs@nvidia.com>,
Danilo Krummrich <dakr@kernel.org>,
Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
nouveau@lists.freedesktop.org
Subject: Re: [PATCH] drm/nouveau: remove unused variable ret
Date: Mon, 29 Jul 2024 15:08:33 +0200 [thread overview]
Message-ID: <ZqeUUea0pL7vKKPr@pollux> (raw)
In-Reply-To: <20240729123624.868907-1-jani.nikula@intel.com>
Hi Jani,
On Mon, Jul 29, 2024 at 03:36:24PM +0300, Jani Nikula wrote:
> Fix build with CONFIG_NOUVEAU_PLATFORM_DRIVER enabled:
>
> ../drivers/gpu/drm/nouveau/nouveau_platform.c: In function ‘nouveau_platform_probe’:
> ../drivers/gpu/drm/nouveau/nouveau_platform.c:29:13: error: unused variable ‘ret’ [-Werror=unused-variable]
> 29 | int ret;
> | ^~~
>
> Fixes: 961ae5f9807b ("drm/nouveau: handle pci/tegra drm_dev_{alloc, register} from common code")
> Cc: Ben Skeggs <bskeggs@nvidia.com>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Thanks for fixing this, applied to drm-misc-next.
>
> ---
>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Danilo Krummrich <dakr@redhat.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> drivers/gpu/drm/nouveau/nouveau_platform.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_platform.c b/drivers/gpu/drm/nouveau/nouveau_platform.c
> index 3194b110eff8..829fdc6e4031 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_platform.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_platform.c
> @@ -26,7 +26,6 @@ static int nouveau_platform_probe(struct platform_device *pdev)
> const struct nvkm_device_tegra_func *func;
> struct nvkm_device *device = NULL;
> struct drm_device *drm;
> - int ret;
>
> func = of_device_get_match_data(&pdev->dev);
>
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-07-29 13:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 12:36 [PATCH] drm/nouveau: remove unused variable ret Jani Nikula
2024-07-29 13:08 ` Danilo Krummrich [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-19 8:40 [PATCH] drm/nouveau: Remove " Jiapeng Chong
2021-03-19 8:40 ` Jiapeng Chong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqeUUea0pL7vKKPr@pollux \
--to=dakr@redhat.com \
--cc=bskeggs@nvidia.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=kherbst@redhat.com \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.