All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Liang <ycliang@andestech.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v2, 1/1] util: atcsmu.c: fix typo and coding style
Date: Wed, 31 Jul 2024 11:34:59 +0800	[thread overview]
Message-ID: <Zqmw4ynJ38mJOFj4@swlinux02> (raw)
In-Reply-To: <1F272D04-075C-4AF0-9FC4-623551D72575@jrtc27.com>

On Wed, Jul 31, 2024 at 04:24:42AM +0100, Jessica Clarke wrote:
> [EXTERNAL MAIL]
> 
> On 31 Jul 2024, at 03:58, Leo Yu-Chi Liang <ycliang@andestech.com> wrote:
> >
> > Fix typo "hard -> hart", printf format and if statement coding style.
> >
> > Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>
> > Reviewed-by: Yu Chien Peter Lin <peterlin@andestech.com>
> 
> 1. Don?t combine changes like this, it makes it hard to see what?s just
> a style change and what?s a behavioural change.
> 
> 2. Early return is often better code like in these cases, but it?s not
> like the existing code is wrong style-wise or hard to read.
> 
> Jess

Hi Jess,

Thanks for the review.
I will split these changes into two patches, 
modify the wording of the commit messages and send a v3 patch ASAP.

Best regards,
Leo


      reply	other threads:[~2024-07-31  3:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31  2:58 [PATCH v2, 1/1] util: atcsmu.c: fix typo and coding style Leo Yu-Chi Liang
2024-07-31  3:24 ` Jessica Clarke
2024-07-31  3:34   ` Leo Liang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zqmw4ynJ38mJOFj4@swlinux02 \
    --to=ycliang@andestech.com \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.