From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/7] xfs_spaceman: edit filesystem properties
Date: Wed, 31 Jul 2024 08:41:58 -0700 [thread overview]
Message-ID: <ZqpbRibHaNodChSt@infradead.org> (raw)
In-Reply-To: <20240730223725.GL6352@frogsfrogsfrogs>
On Tue, Jul 30, 2024 at 03:37:25PM -0700, Darrick J. Wong wrote:
> On Tue, Jul 30, 2024 at 02:41:41PM -0700, Christoph Hellwig wrote:
> > Is this really a xfs_spaceman thingy? The code itself looks fine,
> > but the association with space management is kinda weird.
>
> I dunno. It could just as easily go into xfs_io I suppose; the tiny
> advantage of putting it in spaceman is that spaceman grabs the
> fsgeometry structure on file open so we don't have to do that again.
For the online changes xfs_io seems ok, and for the offline ones xfs_db
seems like a perfevt fit anyway.
next prev parent reply other threads:[~2024-07-31 15:41 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 3:10 [RFC PATCHSET] xfsprogs: filesystem properties Darrick J. Wong
2024-07-30 3:18 ` [PATCHSET v30.9 1/3] " Darrick J. Wong
2024-07-30 3:19 ` [PATCH 1/7] libfrog: support editing filesystem property sets Darrick J. Wong
2024-07-30 21:40 ` Christoph Hellwig
2024-07-30 3:20 ` [PATCH 2/7] xfs_spaceman: edit filesystem properties Darrick J. Wong
2024-07-30 21:41 ` Christoph Hellwig
2024-07-30 22:37 ` Darrick J. Wong
2024-07-31 15:41 ` Christoph Hellwig [this message]
2024-08-02 0:16 ` Dave Chinner
2024-07-30 3:20 ` [PATCH 3/7] xfs_db: improve getting and setting extended attributes Darrick J. Wong
2024-07-30 21:37 ` Christoph Hellwig
2024-07-30 3:20 ` [PATCH 4/7] libxfs: hoist listxattr from xfs_repair Darrick J. Wong
2024-07-30 21:38 ` Christoph Hellwig
2024-07-31 17:55 ` Darrick J. Wong
2024-07-30 3:21 ` [PATCH 5/7] libxfs: pass a transaction context through listxattr Darrick J. Wong
2024-07-30 21:38 ` Christoph Hellwig
2024-07-30 3:21 ` [PATCH 6/7] xfs_db: add a command to list xattrs Darrick J. Wong
2024-07-30 21:39 ` Christoph Hellwig
2024-07-30 3:21 ` [PATCH 7/7] xfs_property: add a new tool to administer fs properties Darrick J. Wong
2024-07-30 21:43 ` Christoph Hellwig
2024-07-30 22:28 ` Darrick J. Wong
2024-07-31 15:42 ` Christoph Hellwig
2024-07-31 17:56 ` Darrick J. Wong
2024-08-02 0:25 ` Dave Chinner
2024-07-30 3:19 ` [PATCHSET v30.9 2/3] xfs_scrub: control of autonomous self healing Darrick J. Wong
2024-07-30 3:21 ` [PATCH 1/3] libfrog: define a self_healing filesystem property Darrick J. Wong
2024-07-30 21:56 ` Christoph Hellwig
2024-07-30 23:51 ` Darrick J. Wong
2024-07-31 15:43 ` Christoph Hellwig
2024-07-31 17:45 ` Darrick J. Wong
2024-07-31 19:43 ` Christoph Hellwig
2024-07-30 3:22 ` [PATCH 2/3] xfs_scrub: allow sysadmin to control background scrubs Darrick J. Wong
2024-07-30 3:22 ` [PATCH 3/3] mkfs: set self_healing property Darrick J. Wong
2024-07-30 3:19 ` [PATCHSET v30.9 3/3] xfs_scrub: separate package for self healing Darrick J. Wong
2024-07-30 3:22 ` [PATCH 1/3] misc: shift install targets Darrick J. Wong
2024-07-30 3:22 ` [PATCH 2/3] xfs_scrub: use the self_healing fsproperty to select mode Darrick J. Wong
2024-07-30 3:23 ` [PATCH 3/3] debian: create a new package for automatic self-healing Darrick J. Wong
2024-07-30 3:19 ` [PATCHSET v30.9] fstests: xfs filesystem properties Darrick J. Wong
2024-07-30 3:23 ` [PATCH 1/1] xfs: functional testing for " Darrick J. Wong
2024-07-30 3:25 ` [PATCHSET v30.9] fstests: xfs " Darrick J. Wong
2024-08-02 0:29 ` [RFC PATCHSET] xfsprogs: " Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqpbRibHaNodChSt@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.