From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, nbd@nbd.name,
lorenzo.bianconi83@gmail.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
linux-arm-kernel@lists.infradead.org, upstream@airoha.com,
angelogioacchino.delregno@collabora.com,
benjamin.larsson@genexis.eu, rkannoth@marvell.com,
sgoutham@marvell.com, andrew@lunn.ch, arnd@arndb.de,
horms@kernel.org
Subject: Re: [PATCH net-next 2/9] net: airoha: Move airoha_queues in airoha_qdma
Date: Thu, 1 Aug 2024 15:22:52 +0200 [thread overview]
Message-ID: <ZquMLCfLA1AV1Dpz@lore-desk> (raw)
In-Reply-To: <20240731191543.2cc0c985@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
> On Tue, 30 Jul 2024 18:22:41 +0200 Lorenzo Bianconi wrote:
> > QDMA controllers available in EN7581 SoC have independent tx/rx hw queues
> > so move them in airoha_queues structure.
>
> You seem to be touching a lot of the same lines you touched in the
> previous patch here :(
> Maybe you can add some of the
>
> + struct airoha_qdma *qdma = &q->eth->qdma[0];
>
> lines, and propagate qdma pointers in the previous patch already?
ack, I will fix it in v2.
Regrads,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-08-01 13:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 16:22 [PATCH net-next 0/9] Add second QDMA support for EN7581 eth controller Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 1/9] net: airoha: Introduce airoha_qdma struct Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 2/9] net: airoha: Move airoha_queues in airoha_qdma Lorenzo Bianconi
2024-08-01 2:15 ` Jakub Kicinski
2024-08-01 13:22 ` Lorenzo Bianconi [this message]
2024-07-30 16:22 ` [PATCH net-next 3/9] net: airoha: Move irq_mask in airoha_qdma structure Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 4/9] net: airoha: Add airoha_qdma pointer in airoha_tx_irq_queue/airoha_queue structures Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 5/9] net: airoha: Use qdma pointer as private structure in airoha_irq_handler routine Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 6/9] net: airoha: Allow mapping IO region for multiple qdma controllers Lorenzo Bianconi
2024-08-01 2:14 ` Jakub Kicinski
2024-08-01 8:36 ` Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 7/9] net: airoha: Clean-up all qdma controllers running airoha_hw_cleanup() Lorenzo Bianconi
2024-08-01 2:14 ` Jakub Kicinski
2024-08-01 8:37 ` Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 8/9] net: airoha: Start all qdma NAPIs in airoha_probe() Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 9/9] net: airoha: Link the gdm port to the selected qdma controller Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZquMLCfLA1AV1Dpz@lore-desk \
--to=lorenzo@kernel.org \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=benjamin.larsson@genexis.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sgoutham@marvell.com \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.