From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Jim Fehlig <jfehlig@suse.com>
Subject: Re: [PATCH 1/2] migration: Fix cleanup of iochannel in file migration
Date: Thu, 1 Aug 2024 14:39:05 -0400 [thread overview]
Message-ID: <ZqvWSYlio5gOVy5I@x1n> (raw)
In-Reply-To: <20240801174101.31806-2-farosas@suse.de>
On Thu, Aug 01, 2024 at 02:41:00PM -0300, Fabiano Rosas wrote:
> The QIOChannelFile object already has its reference decremented by
> g_autoptr. Trying to unref an extra time causes:
>
> ERROR:../qom/object.c:1241:object_unref: assertion failed: (obj->ref > 0)
>
> Fixes: a701c03dec ("migration: Drop reference to QIOChannel if file seeking fails")
> Fixes: 6d3279655a ("migration: Fix file migration with fdset")
> Reported-by: Jim Fehlig <jfehlig@suse.com>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Ouch..
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2024-08-01 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 17:40 [PATCH 0/2] Multifd fixes Fabiano Rosas
2024-08-01 17:41 ` [PATCH 1/2] migration: Fix cleanup of iochannel in file migration Fabiano Rosas
2024-08-01 18:39 ` Peter Xu [this message]
2024-08-01 17:41 ` [PATCH 2/2] migration/multifd: Fix multifd_send_setup cleanup when channel creation fails Fabiano Rosas
2024-08-01 18:38 ` Peter Xu
2024-08-01 19:14 ` Fabiano Rosas
2024-08-02 12:47 ` [PATCH 0/2] Multifd fixes Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqvWSYlio5gOVy5I@x1n \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=jfehlig@suse.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.