From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org, jiri@nvidia.com,
shayd@nvidia.com, wojciech.drewek@intel.com, horms@kernel.org,
sridhar.samudrala@intel.com, mateusz.polchlopek@intel.com,
kalesh-anakkur.purayil@broadcom.com, michal.kubiak@intel.com,
pio.raczynski@gmail.com, przemyslaw.kitszel@intel.com,
jacob.e.keller@intel.com, maciej.fijalkowski@intel.com
Subject: Re: [PATCH net-next v2 00/15][pull request] ice: support devlink subfunction
Date: Fri, 2 Aug 2024 09:35:28 +0200 [thread overview]
Message-ID: <ZqyMQPNZQYXPgiQL@mev-dev.igk.intel.com> (raw)
In-Reply-To: <ZqyDNU3H4LSgkrqR@nanopsycho.orion>
On Fri, Aug 02, 2024 at 08:56:53AM +0200, Jiri Pirko wrote:
> Fri, Aug 02, 2024 at 07:11:48AM CEST, michal.swiatkowski@linux.intel.com wrote:
> >On Thu, Aug 01, 2024 at 04:32:56PM +0200, Jiri Pirko wrote:
> >> Thu, Aug 01, 2024 at 12:10:11AM CEST, anthony.l.nguyen@intel.com wrote:
> >> >Michal Swiatkowski says:
> >> >
> >> >Currently ice driver does not allow creating more than one networking
> >> >device per physical function. The only way to have more hardware backed
> >> >netdev is to use SR-IOV.
> >> >
> >> >Following patchset adds support for devlink port API. For each new
> >> >pcisf type port, driver allocates new VSI, configures all resources
> >> >needed, including dynamically MSIX vectors, program rules and registers
> >> >new netdev.
> >> >
> >> >This series supports only one Tx/Rx queue pair per subfunction.
> >> >
> >> >Example commands:
> >> >devlink port add pci/0000:31:00.1 flavour pcisf pfnum 1 sfnum 1000
> >> >devlink port function set pci/0000:31:00.1/1 hw_addr 00:00:00:00:03:14
> >> >devlink port function set pci/0000:31:00.1/1 state active
> >> >devlink port function del pci/0000:31:00.1/1
> >> >
> >> >Make the port representor and eswitch code generic to support
> >> >subfunction representor type.
> >> >
> >> >VSI configuration is slightly different between VF and SF. It needs to
> >> >be reflected in the code.
> >> >---
> >> >v2:
> >> >- Add more recipients
> >> >
> >> >v1: https://lore.kernel.org/netdev/20240729223431.681842-1-anthony.l.nguyen@intel.com/
> >>
> >> I'm confused a bit. This is certainly not v2. I replied to couple
> >> versions before. There is no changelog. Hard to track changes :/
> >
> >You can see all changes here:
> >https://lore.kernel.org/netdev/20240606112503.1939759-1-michal.swiatkowski@linux.intel.com/
> >
> >This is pull request from Tony, no changes between it and version from
> >iwl.
>
> Why the changelog can't be here too? It's still the same patchset, isn't
> it?
>
Correct it is the same patchset. I don't know, I though it is normal
that PR is starting from v1, feels like it was always like that.
Probably Tony is better person to ask about the process here.
> >
next prev parent reply other threads:[~2024-08-02 7:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 22:10 [PATCH net-next v2 00/15][pull request] ice: support devlink subfunction Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 01/15] ice: add new VSI type for subfunctions Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 02/15] ice: export ice ndo_ops functions Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 03/15] ice: add basic devlink subfunctions support Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 04/15] ice: treat subfunction VSI the same as PF VSI Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 05/15] ice: allocate devlink for subfunction Tony Nguyen
2024-08-01 14:41 ` Jiri Pirko
2024-08-02 5:05 ` Michal Swiatkowski
2024-07-31 22:10 ` [PATCH net-next v2 06/15] ice: base subfunction aux driver Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 07/15] ice: implement netdev for subfunction Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 08/15] ice: make representor code generic Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 09/15] ice: create port representor for SF Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 10/15] ice: don't set target VSI for subfunction Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 11/15] ice: check if SF is ready in ethtool ops Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 12/15] ice: implement netdevice ops for SF representor Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 13/15] ice: support subfunction devlink Tx topology Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 14/15] ice: basic support for VLAN in subfunctions Tony Nguyen
2024-07-31 22:10 ` [PATCH net-next v2 15/15] ice: allow to activate and deactivate subfunction Tony Nguyen
2024-08-01 14:59 ` Jiri Pirko
2024-08-02 4:55 ` Michal Swiatkowski
2024-08-01 14:32 ` [PATCH net-next v2 00/15][pull request] ice: support devlink subfunction Jiri Pirko
2024-08-02 5:11 ` Michal Swiatkowski
2024-08-02 6:56 ` Jiri Pirko
2024-08-02 7:35 ` Michal Swiatkowski [this message]
2024-08-02 17:38 ` Tony Nguyen
2024-08-03 6:51 ` Jiri Pirko
2024-08-06 21:13 ` Tony Nguyen
2024-08-01 14:35 ` Jiri Pirko
2024-08-02 4:48 ` Michal Swiatkowski
2024-08-02 7:30 ` Michal Swiatkowski
2024-08-02 7:38 ` Michal Swiatkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqyMQPNZQYXPgiQL@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=mateusz.polchlopek@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pio.raczynski@gmail.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shayd@nvidia.com \
--cc=sridhar.samudrala@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.