From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Frank Li <Frank.li@nxp.com>
Cc: Marek Vasut <marex@denx.de>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Hasemeyer <markhas@chromium.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
TOUCHSCREEN)..." <linux-input@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
imx@lists.linux.dev
Subject: Re: [PATCH v2 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml
Date: Thu, 15 Aug 2024 12:14:32 -0700 [thread overview]
Message-ID: <Zr5TmAkd67XcyYvJ@google.com> (raw)
In-Reply-To: <Zr5RwL5qRVBKbHcc@lizhi-Precision-Tower-5810>
On Thu, Aug 15, 2024 at 03:06:40PM -0400, Frank Li wrote:
> On Thu, Aug 15, 2024 at 08:44:56PM +0200, Marek Vasut wrote:
> > On 8/15/24 6:14 PM, Frank Li wrote:
> >
> > [...]
> >
> > > + ti,debounce-max:
> > > + deprecated: true
> > > + $ref: /schemas/types.yaml#/definitions/uint16
> > > + description: Max number of additional readings per sample (u16).
> >
> > Could you drop the (u16) which is already part of the $ref'd type ?
>
> Sorry, I forget it.
>
> >
> > [...]
> >
> > > + ti,x-max:
> > > + deprecated: true
> > > + $ref: /schemas/types.yaml#/definitions/uint16
> > > + description: Maximum value on the X axis (u16).
> > > +
> > > + ti,x-min:
> >
> > Is this deprecated too, the same way as x-max above is deprecated ?
>
> I am not sure. I guest x-min and y-min is still useful becasue it may
> indicate invalidated touch. but x-max and y-max should not usefull because
> max value should be Vcc. x-min and y-min help filter out some noise.
There are standard properties touchscreen-min-x and touchscreen-min-y
that will be used if present, so I think ti,x-min can also be marked as
deprecated.
Thanks.
--
Dmitry
prev parent reply other threads:[~2024-08-15 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 16:14 [PATCH v2 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml Frank Li
2024-08-15 18:44 ` Marek Vasut
2024-08-15 19:06 ` Frank Li
2024-08-15 19:14 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zr5TmAkd67XcyYvJ@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=Frank.li@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=markhas@chromium.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.