All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Neuschäfer" <j.neuschaefer@gmx.net>
To: Andre Przywara <andre.przywara@arm.com>
Cc: "Will Deacon" <will@kernel.org>,
	"Julien Thierry" <julien.thierry.kdev@gmail.com>,
	kvm@vger.kernel.org,
	"Alexandru Elisei" <alexandru.elisei@arm.com>,
	"J . Neuschäfer" <j.neuschaefer@gmx.net>
Subject: Re: [PATCH kvmtool] remove wordsize.h inclusion (for musl compatibility)
Date: Mon, 5 Aug 2024 01:15:27 +0200	[thread overview]
Message-ID: <ZrALjzvENZLJqhLv@probook> (raw)
In-Reply-To: <20240801111054.818765-1-andre.przywara@arm.com>

On Thu, Aug 01, 2024 at 12:10:54PM +0100, Andre Przywara wrote:
> The wordsize.h header file and the __WORDSIZE definition do not seem
> to be universal, the musl libc for instance has the definition in a
> different header file. This breaks compilation of kvmtool against musl.
>
> The two leading underscores suggest a compiler-internal symbol anyway, so
> let's just remove that particular macro usage entirely, and replace it
> with the number we really want: the size of a "long" type.
>
> Reported-by: J. Neuschäfer <j.neuschaefer@gmx.net>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> Hi,
>
> can someone test this on a proper/pure musl installation? I tested this
> with Ubuntu's musl-gcc wrapper, but this didn't show the problem before,
> so I guess there are subtle differences.

Compile-tested successfully on Alpine Linux 3.21 (gcc 13.2.1, musl 1.2.5).

Thanks a lot!
-- jn

  parent reply	other threads:[~2024-08-04 23:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-01 11:10 [PATCH kvmtool] remove wordsize.h inclusion (for musl compatibility) Andre Przywara
2024-08-02  9:55 ` Alexandru Elisei
2024-08-04 23:15 ` J. Neuschäfer [this message]
2024-08-05 13:43 ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrALjzvENZLJqhLv@probook \
    --to=j.neuschaefer@gmx.net \
    --cc=alexandru.elisei@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.