Re: [Buildroot] [PATCH 1/1] package/zfs: bump version to 2.2.4

[Waldemar Brodkorb <wbx@openadk.org>]

Hi,
José Luis Salvador Rufo wrote,

> Hello Waldemar Brodkorb,
> 
> I saw the commit https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/commit/?id=
> 05b11809bd11450aff3d20e43f18415ce58601e7 that defines SEEK_DATA and SEEK_HOLE.
> However, I noticed that the following code could fail at runtime: https://
> cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/libc/sysdeps/linux/common/
> lseek.c?id=05b11809bd11450aff3d20e43f18415ce58601e7#n44

Do you understand the ifdef constructions? Under which condition it
will use this code?
 
> Should SEEK_DATA and SEEK_HOLE be included here as well?

Not sure. Do you have a simple test case I can try?

best regards
 Waldemar
 
> Regards.
> 
> El lun, 22 jul 2024 a las 15:18, Thomas Petazzoni (<
> thomas.petazzoni@bootlin.com>) escribió:
> 
>     Hello José,
> 
>     Thanks for your super quick feedback!
> 
>     On Mon, 22 Jul 2024 15:01:45 +0200
>     José Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:
> 
>     > In the meantime, I recommend the following options:
>     >
>     > A) Revert to the previous version (OpenZFS v2.2.3). This is not ideal for
>     > people who have already upgraded.
>     >
>     > B) Include a work-in-progress (it works for buildroot, I tested it)
>     patch:
>     > https://github.com/openzfs/zfs/pull/16169.patch.
> 
>     Please do this option (B), and also contribute SEEK_DATA support to
>     uClibc. I've added Waldemar, the uClibc-ng maintainer, in Cc.
> 
>     Thanks a lot!
> 
>     Thomas
>     --
>     Thomas Petazzoni, co-owner and CEO, Bootlin
>     Embedded Linux and Kernel engineering and training
>     https://bootlin.com
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot