All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: AbdAlRahman Gad <abdobngad@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 5/6] [Newcomer] t7004-tag: here-doc modernization
Date: Mon, 5 Aug 2024 11:42:01 +0200	[thread overview]
Message-ID: <ZrCeaU4VKxPYTPiJ@tanuki> (raw)
In-Reply-To: <20240804071137.30326-6-abdobngad@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

On Sun, Aug 04, 2024 at 10:11:36AM +0300, AbdAlRahman Gad wrote:
> use <<-\EOF to indent here-doc

Instead of what? It would help to mention that the change converts from
<<\EOF to <<\-EOF, where the latter allows us to indent the body.

I'd also suggest a commit title like "t7004: use indented here docs", as
"here doc modernizations" doesn't quite give you a hint what the
modernization looks like.

Patrick

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-08-05  9:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-04  7:11 [PATCH v3 0/6] [Newcomer] t7004: modernize the style AbdAlRahman Gad
2024-08-04  7:11 ` [PATCH v3 1/6] [Newcomer] t7004-tag: redirection operator AbdAlRahman Gad
2024-08-05  9:36   ` Patrick Steinhardt
2024-08-04  7:11 ` [PATCH v3 2/6] [Newcomer] t7004-tag: do not lose exit status to pipe AbdAlRahman Gad
2024-08-05  9:36   ` Patrick Steinhardt
2024-08-04  7:11 ` [PATCH v3 3/6] [Newcomer] t7004-tag: one command per line AbdAlRahman Gad
2024-08-05  9:36   ` Patrick Steinhardt
2024-08-04  7:11 ` [PATCH v3 4/6] [Newcomer] t7004-tag: do not prepare except outside test_expect_success AbdAlRahman Gad
2024-08-04  7:32   ` Eric Sunshine
2024-08-04  9:01     ` AbdAlRahman Gad
2024-08-04 16:46   ` Junio C Hamano
2024-08-04  7:11 ` [PATCH v3 5/6] [Newcomer] t7004-tag: here-doc modernization AbdAlRahman Gad
2024-08-05  9:42   ` Patrick Steinhardt [this message]
2024-08-04  7:11 ` [PATCH v3 6/6] [Newcomer] t7004-tag: description on the same line as test_expect_success AbdAlRahman Gad
2024-08-05  9:42   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrCeaU4VKxPYTPiJ@tanuki \
    --to=ps@pks.im \
    --cc=abdobngad@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.