From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39324C52D73 for ; Wed, 7 Aug 2024 18:46:48 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sblfo-0004hD-7A; Wed, 07 Aug 2024 14:46:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sblfm-0004ft-ML for qemu-riscv@nongnu.org; Wed, 07 Aug 2024 14:46:10 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sblfk-0008Ui-9V for qemu-riscv@nongnu.org; Wed, 07 Aug 2024 14:46:09 -0400 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-7a18ba4143bso130108a12.2 for ; Wed, 07 Aug 2024 11:46:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1723056367; x=1723661167; darn=nongnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=veeAhpkiXHbDJbR7MUt6Adrx2FAUlHB3pWMaxf/ta98=; b=uzb4Q5sjPRmWo1+tc7zt3HFovp9wn/GvqZh/FLE+rDnRj3udsDhCHr55vXfOUsqAeO gWZplsPrATxFcFGcJW9WlVmbBX0FMCYNYjJHXRZ3tq8MQ8/PD9wcNUmqy0u94zPGt/D9 /7gfyhOddk7eRWdDpo6riMuqxUiAT+W3sI1sJFAbGTDwtawe/qDtahyTb9uKTI/tQar9 DwpVN8Lb22cWjt6veQSQGZbgy2409nQzA7fvR6XnD0Sp4GTD/OcD0sCfJoPmBxO1L9Gj 5xWTQkOqFBCwmG7hihUxx8mQkXPQA9DSyGIU5Pfg0FkZfIy5/OXpCiI5DpisuBJk/vHR i4/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723056367; x=1723661167; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=veeAhpkiXHbDJbR7MUt6Adrx2FAUlHB3pWMaxf/ta98=; b=FLkwZe93PExN/VWbUF3HtOR8EeTv0Eekk2m238E9b/qFkxiiCDD33K4S7jTCAUcyor t+Tfwjx0gfR9L9B1ObY9qzmb+H6Hb0LqRzgngLCN12VVjX9/EEAA6mRgD7V6LxC7R0sS XSkSZZXct9OwE7SpyyxHZViPl3LjA1X/PzmV/4QSrcichodBJtdQr2FWj+xOfgtnO5p4 2CIEtm4ReSMECprsiXGRDeFlfjV+o4WbLh4VNV0Keipu1/m71CFnsYzj8Uoz57lpq1pj 8Fdg4wJIhDln38Wi9sCz+jc+CQlCpIsGLAhM3I91U2oZzJPmHQajYd65K90W6K5phMGz nzEQ== X-Forwarded-Encrypted: i=1; AJvYcCX4mW6Ii7rNihJD9Mj5VEGLY9+AnPKa5s4I1sn3HFMPZGJ7MPI6bZIWnFwLnF+dkPIeNQN09KcL7A2ZqlcWRwWdck7i0Ps= X-Gm-Message-State: AOJu0YwG5/81tKybvhvSo29cwpEjlB+02bq5yCwg7PpuEJ6t3m8PiOKt krOLzuc+haIwlSJfyuidHErCNPp0q0pC7pV/3m24sx8NxYP2fdejPtzuZIjyoP8= X-Google-Smtp-Source: AGHT+IG6X+pntY3MMDnQr2s2cprjSL15IGFycdf82EuUa+QLRS5IK8Hmf4suU0LOBYvRHIjAtOKdAg== X-Received: by 2002:a05:6a20:8727:b0:1c4:8876:2ae with SMTP id adf61e73a8af0-1c69966e83bmr14693923637.41.1723056366454; Wed, 07 Aug 2024 11:46:06 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7b764fba58bsm7381953a12.72.2024.08.07.11.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 11:46:06 -0700 (PDT) Date: Wed, 7 Aug 2024 11:46:04 -0700 From: Deepak Gupta To: Richard Henderson Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, pbonzini@redhat.com, palmer@dabbelt.com, Alistair.Francis@wdc.com, laurent@vivier.eu, bmeng.cn@gmail.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, Jim Shu , Andy Chiu Subject: Re: [PATCH v3 03/20] target/riscv: Introduce elp state and enabling controls for zicfilp Message-ID: References: <20240807000652.1417776-1-debug@rivosinc.com> <20240807000652.1417776-4-debug@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::535; envelope-from=debug@rivosinc.com; helo=mail-pg1-x535.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On Wed, Aug 07, 2024 at 10:56:12AM +1000, Richard Henderson wrote: >On 8/7/24 10:06, Deepak Gupta wrote: >>+/* enum for branch tracking state in cpu/hart */ >>+typedef enum { >>+ NO_LP_EXPECTED = 0, >>+ LP_EXPECTED = 1, >>+} cfi_elp; > >I know this is language is in the spec, but would it make more sense to use > > bool elp_expected; > >? Sounds reasonable to me. Will take the suggestion. > >If not, Coding Style requires CamelCase for typedefs. > > >r~