From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE138C3DA7F for ; Wed, 7 Aug 2024 20:22:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbnAU-0001kw-SX; Wed, 07 Aug 2024 16:21:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbnAS-0001jJ-Qq for qemu-riscv@nongnu.org; Wed, 07 Aug 2024 16:21:56 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbnAR-00069f-AT for qemu-riscv@nongnu.org; Wed, 07 Aug 2024 16:21:56 -0400 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1fc611a0f8cso2870875ad.2 for ; Wed, 07 Aug 2024 13:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1723062113; x=1723666913; darn=nongnu.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=lWBaTJW8YUN9Vv2IVGuCHyEf8675XQT6DIsnuhv+O4k=; b=nTFsUh4OfqzrtTIm7rltuoo6Sxc4zoK9snj84gG7J0/Qj1sqSsBmQvlnN2WWtnKAB+ Khv9RRrWKk7garmhwZCTEaxho41HZBjI4tRWxlaf67TmJp2ERw/5gFS3zZCB7VdZEO5u sCSqGNF4IuoJXeYi97gbFP4C1W9h0FlbKMaTQhO0E5s+iroDG22tUNVR6ERorKaHSK6n WDbt9sXSYdZLr4TSq4qWr6Ap5B7DA3tddVUySxtQ5vhkxIqOY7T3BW681MYHJHPXXlbD 7XbYQdKn0IdUD8FtX98EfvIw8AIZhP066AYxYTSI6y2xiku6WpZJunKN0h4B+TZ7zJUj /z2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723062113; x=1723666913; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lWBaTJW8YUN9Vv2IVGuCHyEf8675XQT6DIsnuhv+O4k=; b=IbVbeptyecb58eU/ZLrv7cQkOysIyJa5Ae6krsUSXPIQLG8S59QS7khtO+ltFSs4Da rqukMo8hPn4+PGnc9toGSMy64CkJ9FLVZy+xWTFK07lou0ujL6A4cFUO3pHioRG4HQ+w Y4JXwPnCOpwKIwNFs85d4O1h187vlaGUZuK/yt4j7uTuuvF1SP9wFCWt5PDhxCZi2DyH grJ592oXgysGcWTCZi1w5QIADwwwh1A8rvfi1Ic8bcZZNQF6SqSs6rLnMEV7RLEU07/i Uv8Mjs02WWj18aRlLfzbzlcdxL318XnIU2j/sbZkEBo5wuD4zSaZ80ubl0Y9ZFlWTyfr PSmg== X-Forwarded-Encrypted: i=1; AJvYcCXDwas4NIvCz3OBLAC4fssB3xVLfL8EC9N9XE+mumDUKNcegT/6dy3HHTL3/mxHQxqTo/oifYd6Rcc4vuUWFft6d8G8wtg= X-Gm-Message-State: AOJu0Yy1+Uj0Vze8zKgnEigUHDePRQM8uj061iQcbSUGiIdwWsHPhzZr cHtFnsBWm8n8k+vhBC/EZGsOpE/8pBPieMI0vSRi38lU4ZYu2xLv+D4MA+8qdIM= X-Google-Smtp-Source: AGHT+IGehvdY/LCmIzhzihA59V5sUEgpEiaAoksO39cuwv+c4kNT+f7TkKLDMZx/4Ni0xKpxqLknAw== X-Received: by 2002:a17:902:c405:b0:1fd:8f66:b078 with SMTP id d9443c01a7336-1ff573b55c9mr218868905ad.46.1723062112536; Wed, 07 Aug 2024 13:21:52 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ff58f19af1sm110771295ad.47.2024.08.07.13.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 13:21:52 -0700 (PDT) Date: Wed, 7 Aug 2024 13:21:49 -0700 From: Deepak Gupta To: Richard Henderson Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, pbonzini@redhat.com, palmer@dabbelt.com, Alistair.Francis@wdc.com, laurent@vivier.eu, bmeng.cn@gmail.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, Jim Shu , Andy Chiu Subject: Re: [PATCH v3 10/20] target/riscv: introduce ssp and enabling controls for zicfiss Message-ID: References: <20240807000652.1417776-1-debug@rivosinc.com> <20240807000652.1417776-11-debug@rivosinc.com> <34411ccd-5fc8-46d8-bf5e-871949c755fb@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=debug@rivosinc.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On Wed, Aug 07, 2024 at 12:12:52PM +1000, Richard Henderson wrote: >On 8/7/24 12:11, Richard Henderson wrote: >>On 8/7/24 10:06, Deepak Gupta wrote: >>>diff --git a/target/riscv/csr.c b/target/riscv/csr.c >>>index a5a969a377..d72d6289fb 100644 >>>--- a/target/riscv/csr.c >>>+++ b/target/riscv/csr.c >>>@@ -185,6 +185,47 @@ static RISCVException zcmt(CPURISCVState *env, int csrno) >>>      return RISCV_EXCP_NONE; >>>  } >>>+static RISCVException cfi_ss(CPURISCVState *env, int csrno) >>>+{ >>>+    /* no cfi extension, access to csr is illegal */ >>>+    if (!env_archcpu(env)->cfg.ext_zicfiss) { >>>+        return RISCV_EXCP_ILLEGAL_INST; >>>+    } >>>+    /* >>>+     * CONFIG_USER_MODE always allow access for now. Better for user mode only >>>+     * functionality >>>+     */ >> >>In the next patch you add ubcfien, which would apply here. > >... anyway, surely cpu_get_bcfien() is the right check anyway? Yeah you're right, `cpu_get_bcfien()` works and simplify it. will fix it. > > >r~