From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:504:7fd7:b0:1be9:327d:8ee3 with SMTP id hj23csp474412njc; Thu, 8 Aug 2024 04:54:29 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXFDohDkKh6LtpnT5h5ubxkMPIIXWkv3Y7LcnhTi0cvO2e0xEMKHhm6KZYKYbDledM6ZXcM9y15LELpNepKtUuyIX5MUsLV X-Google-Smtp-Source: AGHT+IGQargv8A7u/n+B/louWezCD4aeaTeBNo4aK757FzmernEmLzJg/TQmHnhwSRm2ogSuankB X-Received: by 2002:a05:620a:240d:b0:7a1:d08b:5b7d with SMTP id af79cd13be357-7a38188e432mr208786385a.62.1723118069158; Thu, 08 Aug 2024 04:54:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1723118069; cv=none; d=google.com; s=arc-20160816; b=GdizhU3wx007VTGyHj/VTnZxci3nACovgoVeAJIJJ49geUdIOq0BMabLX31ySQyUFw u5+B9hWB7zCgVd1HrtLCwkWB5mM1sH6OhhIetq7wgFF4T4h6FtRQVbXKxdg74FijLAKe GUrCeFxQ3spermH4p8I+4Ul7tvpkaPlHpRf5t5z9hsdCCXTm6RDkhS7jI6y6ziocIRU2 KESKjIww+7ZqcLhmo2I5Mxr+3dQ6rvJrTQ+hpInbOz00uE2UYm0KTIdIdY9HILQ4Od0r Xpn7RWjF+umHz5jFRrEou6fBzmXuLvZ2kZhxD5klDouedVt0JJVUlk0mMKiL1TRo5aYF RCWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:user-agent :in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=LliZeF9//nODySI40QD/AChiQPaPnchmIz31scbPlIg=; fh=n5fSrY/QQONNbtoUknvIjCuW4gOb7tRDldWPwx49bNw=; b=NkTZNy05vasJj8GpHCseWq5rSOm9T7bklwgrUa5856FRCtpQX4uhSkprc9NfOiGaCo 2p9WW48QtwQ8Xk+wUJfnOcF/QUzKYxQNfd3PH0CS8J8iram40HfOHZdY6vs+jHZBHLXc BV87iiJjdB+vupkr4r9U7DRy27C6ICSMd+AFt+hZ6/5xog98tsI9/v3ZloVFVTRLXNY3 iwF2eSRzYJS20DVxrTGYsAP+cuEHvmU9EiEQAVx1V52QzSrGNkKNVqY6tVwseBtkRN1k fThE7woiQ2uGDeko/3SaKps2X+CW+mSv/8xk0lPMoUJ1vse0jRGcqw48jiVVu6PfQEXD aB9g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cozQ6FR3; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7a378710eddsi409899885a.337.2024.08.08.04.54.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Aug 2024 04:54:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cozQ6FR3; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sc1iZ-0008Cx-2D; Thu, 08 Aug 2024 07:54:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sc1iY-0008BT-8Z for qemu-arm@nongnu.org; Thu, 08 Aug 2024 07:54:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sc1iW-0000Ao-Ek for qemu-arm@nongnu.org; Thu, 08 Aug 2024 07:54:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723118043; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LliZeF9//nODySI40QD/AChiQPaPnchmIz31scbPlIg=; b=cozQ6FR3+DrROgUWrJFfgSUWLvFWarT4ns7osl+/S5LlOSLWXLAjB4/DMlA0aye2EAQiJ6 x802GEj+outhsv7O2oWoboW1x99891AGIiUOmVZ/kuY/gUNB35wOq+CwBTNJXzVF9njM0C GvhZtGdocGlTdAeWvcS8jDIqxR1/5bM= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-iv60DxAoPhKndKOb76j2dg-1; Thu, 08 Aug 2024 07:54:00 -0400 X-MC-Unique: iv60DxAoPhKndKOb76j2dg-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 182C21874466; Thu, 8 Aug 2024 11:48:50 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.163]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 87F3E195606B; Thu, 8 Aug 2024 11:48:43 +0000 (UTC) Date: Thu, 8 Aug 2024 12:48:39 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Cc: Markus Armbruster , Richard Henderson , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Eric Blake , qemu-arm@nongnu.org, Thomas Huth Subject: Re: [RFC PATCH-for-9.1? 1/2] target/arm: Move qmp_query_gic_capabilities() to hw/intc/ Message-ID: References: <20240806141940.22095-1-philmd@linaro.org> <20240806141940.22095-2-philmd@linaro.org> <87bk23skhq.fsf@pond.sub.org> <87ed6z1j77.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.141, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: saD8XPrFolm6 On Thu, Aug 08, 2024 at 12:32:35PM +0100, Peter Maydell wrote: > On Thu, 8 Aug 2024 at 12:23, Daniel P. Berrangé wrote: > > On Thu, Aug 08, 2024 at 11:15:17AM +0100, Peter Maydell wrote: > > > It's not possible to use KVM with that machine type, so the > > > question is a bit moot. (This also indicates that the > > > interface is not very helpful -- it purports to tell the > > > management layer whether it can use an accelerated in-kernel > > > GIC, but because it doesn't specifiy the board type there's > > > no way to provide an accurate answer. It would be useful > > > to know exactly what libvirt/etc actually use this for...) > > > > Libvirt uses this exclusively with the arm 'virt' machine type. > > > > If the user didn't express any GIC preference, then if KVM is in use, > > we'll pick the highest GIC version QEMU reports as supported. > > You can get that without querying QEMU by asking for 'gic-version=max' > if you like. This isn't in the VM startup path. It is when we expand the user provided XML config into an ABI stable XML config by filling in the blanks left by the user. So we need to actually query the values available. > > If TCG > > is in use we'll always pick v2, even if QEMU reports v3 is emulatable > > due to the v3 impl lacking MSI controller which we need for PCI-e > > Our emulated GICv3 supports the ITS which has MSI support, so I'm not > sure what forcing GICv2 is getting you here. Looking at the linked > RHEL bugzilla bug, I suspect this is an out-of-date policy from before > we added the ITS emulation in 2021 (it's present by default > in virt-2.8 and later machine types). So that is something that > libvirt should update I think. It looks like it is virt-6.2 or later, and libvirt can probe it by looking for existence of the arm-gicv3-its QOM type IIUC. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|