From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:504:7fd7:b0:1be9:327d:8ee3 with SMTP id hj23csp801444njc; Fri, 9 Aug 2024 02:13:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUb1PLqB+G0iK5DzA6GSfVdetY4f323EVmUbOwbeqXf4ajYB0bXV6NPs+vyEUFf23tHCju X-Received: by 2002:a05:620a:24cb:b0:7a1:e214:34df with SMTP id af79cd13be357-7a4c18c5c36mr97338685a.65.1723194836321; Fri, 09 Aug 2024 02:13:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1723194836; cv=none; d=google.com; s=arc-20160816; b=Q0AWbRSV2qw+guXhmS/PrQcTjmSorKoxIK5J44VUhKRqYF2olke8MXycisEfe1O7Hb vOYUWfX9Vr+gZzDOoCm3n7w7oBFB8PuexQf82s+j7Z8rlzuLtp18L7nfAughTOZ7gyMM mhFDMtwPP8Ocj2YvaH/G0P/docdVFB6is/o2Ubb7oERIoxf3THyugLQMNdPIWfZW4lUe XXxRfeZLm3ur2KULcY0EAiH53gJJ1oCYZeNTckrbK+6SbP48KitpEyH/H/xnyJMuWmLd pryi9MRuM3rNscdOB+MK3YdLyEBQ+bv+NIcmA1HRWHn56iP6eu3XccIemVXHH/GDvS9I RyFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=uFrra4R8yOLqWRrGK3eT9VFxFEpTpBMMZdWcI907WFU=; fh=vYu/CVw3OCyE4oNOYoiqzmSJgldE3mgCLtGO3u/JDNc=; b=HIBYOmNciK4bPHTmdNFeSpF70t6aGeJyFDIl9FyM18sr8HcbGpMH+33+BvtQqe5+un kEiYc0FO42vUGurXPYm2LTV6DOPqFYthtsVeWNX51uzA/A58kOO1o+jeHUOEjFDG9+8K wDdc7YyW4OpL1H9K1uJ1C0FJ0Q9aENJbqGNsaszFQ8TJdswlWCZGgAC7YHv9PyKAjCOY g2sTGybO481gmN0ADwLpuc0F+VN8RplZIFzxL5WRPqtuMlWYixmVEPPE4y2ubwdq0ufS houfQXChcYOYNc9yrx/z1NSu0l/yw2mRBDiiptJVAqLMfXNRx4Ba7wbdvN5lE6XxjuXb lYUA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="du/novCZ"; spf=pass (google.com: domain of berrange@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=berrange@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com. [170.10.129.124]) by mx.google.com with ESMTPS id af79cd13be357-7a378805c9asi630035285a.292.2024.08.09.02.13.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 02:13:56 -0700 (PDT) Received-SPF: pass (google.com: domain of berrange@redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="du/novCZ"; spf=pass (google.com: domain of berrange@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=berrange@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723194836; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uFrra4R8yOLqWRrGK3eT9VFxFEpTpBMMZdWcI907WFU=; b=du/novCZjgKnYns2ACDAePdeDRoV194i+HquqlOR5Kfmuk9+87+2Y0WWXbd/5Rsr5ID2nZ opX6JtgaMoPzKolRL/6zcPUl5dzJYHZKRzy5sQcRmRr1Dj62ZXV2iX2SUByhkNziQAtT76 boRFCFgIS5SdDLAghqtBRSAnd/UMDms= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-9d2e-TY0PSmn2hkXj1ZTKA-1; Fri, 09 Aug 2024 05:13:54 -0400 X-MC-Unique: 9d2e-TY0PSmn2hkXj1ZTKA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 287F719560B6; Fri, 9 Aug 2024 09:13:53 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.27]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9F51519560AE; Fri, 9 Aug 2024 09:13:47 +0000 (UTC) Date: Fri, 9 Aug 2024 10:13:44 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Octavian Purdila Cc: Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org, stefanst@google.com, pbonzini@redhat.com, thuth@redhat.com, peter.maydell@linaro.org, marcandre.lureau@redhat.com, alistair@alistair23.me, philmd@linaro.org, jsnow@redhat.com, crosa@redhat.com, bleal@redhat.com Subject: Re: [RFC PATCH 04/23] hw/arm: add SVD file for NXP i.MX RT595 Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20240805201719.2345596-1-tavip@google.com> <20240805201719.2345596-5-tavip@google.com> <87sevhrbjm.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-TUID: uG3GPZGfnEWk On Tue, Aug 06, 2024 at 01:31:51PM -0700, Octavian Purdila wrote: > On Tue, Aug 6, 2024 at 7:06 AM Alex Bennée wrote: > > > > Octavian Purdila writes: > > > > > Picked from: > > > > > > https://github.com/nxp-mcuxpresso/mcux-soc-svd/blob/main/MIMXRT595S/MIMXRT595S_cm33.xml > > > > > > NOTE: the file is truncated to keep the email size reasonable. Please > > > use the link above and download the full file if you want to try out > > > the patch. "the file is truncated" wins understatement of the week. The full XML file that would need to be in QEMU git for this is 8.6 MB in size. The overall generated headers that we get from it are ~16k lines, or ~0.5 MB $ wc -l build/hw/arm/svd/*.h 135 build/hw/arm/svd/flexcomm.h 1227 build/hw/arm/svd/flexcomm_i2c.h 1161 build/hw/arm/svd/flexcomm_spi.h 1231 build/hw/arm/svd/flexcomm_usart.h 2243 build/hw/arm/svd/flexspi.h 3100 build/hw/arm/svd/rt500_clkctl0.h 4022 build/hw/arm/svd/rt500_clkctl1.h 64 build/hw/arm/svd/rt500.h 1073 build/hw/arm/svd/rt500_rstctl0.h 1697 build/hw/arm/svd/rt500_rstctl1.h 15953 total $ wc -c build/hw/arm/svd/*.h 4349 build/hw/arm/svd/flexcomm.h 51135 build/hw/arm/svd/flexcomm_i2c.h 43822 build/hw/arm/svd/flexcomm_spi.h 46331 build/hw/arm/svd/flexcomm_usart.h 89224 build/hw/arm/svd/flexspi.h 113952 build/hw/arm/svd/rt500_clkctl0.h 141885 build/hw/arm/svd/rt500_clkctl1.h 1881 build/hw/arm/svd/rt500.h 38881 build/hw/arm/svd/rt500_rstctl0.h 61449 build/hw/arm/svd/rt500_rstctl1.h 592909 total > > > > > > Signed-off-by: Octavian Purdila > > > --- > > > hw/arm/svd/MIMXRT595S_cm33.xml | 224052 > > > ++++++++++++++++++++++++++++++ > > > > I guess one thing we need to decide is if the source XML should live in > > the repository as the preferred method of making changes or just the > > translations generated by the tool. > > > > I think we might want to store the XML in the qemu repo, even if we > don't use it to generate the header files at compile time. This avoids > issues with the original XML moving, going away, changed in > incompatible ways, etc. > > As for generating the headers at compile time, I don't have a strong > preference. I like it because there is slightly less work to do and it > avoids dealing with resolving changes on both the SVD and the > generated headers. For example, the initial headers are committed, > then some changes are done directly to the headers and then we want to > pick up a new SVD from the vendor to support a new hardware revision. IIUC the structs/enums/etc are defining guest ABI. So if we want to preserve guest ABI for these devices across QEMU releases, we don't want the generated output to be arbitrarily changing. If there are different revisions of a device, we might need separate structs for each maintained in parallel. > > There are disadvantages as well: pysvd dependency for building qemu, > hard to review if the vendor dumps a new version with lots of changes > and we want to update to it for a new hardware revision, slight > increase in build time. > > > > 1 file changed, 224052 insertions(+) > > > create mode 100644 hw/arm/svd/MIMXRT595S_cm33.xml > > > > > > diff --git a/hw/arm/svd/MIMXRT595S_cm33.xml b/hw/arm/svd/MIMXRT595S_cm33.xml > > > new file mode 100644 > > > index 0000000000..8943aa3555 > > > --- /dev/null > > > +++ b/hw/arm/svd/MIMXRT595S_cm33.xml > > > @@ -0,0 +1,1725 @@ > > > + > > > + > > > + nxp.com > > > + MIMXRT595S_cm33 > > > + 1.0 > > > + MIMXRT595SFAWC,MIMXRT595SFFOC > > > + > > > +Copyright 2016-2023 NXP > > > +SPDX-License-Identifier: BSD-3-Clause > > > + > > > > This certainly seems compatible. XML is not the medium I personally > > would have chosen as a register specification language but I guess there > > are no other alternatives? > > > > I agree that the choice of XML is unfortunate but I am not aware of > alternatives, this is what vendors will provide. Given the size of the XML I'm inclined to say that we should just be committing the generated header files to qemu.git Then add https://github.com/nxp-mcuxpresso/mcux-soc-svd as a git submodule, and provide some meson rules for triggering re-generation that are off-by-default. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|