Re: [PATCH] perf stat: Display iostat headers correctly

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Fri, Aug 16, 2024 at 10:34:29AM -0700, Namhyung Kim wrote:
> On Fri, Aug 02, 2024 at 02:58:00PM +0800, Yicong Yang wrote:
> > From: Yicong Yang <yangyicong@hisilicon.com>
> > 
> > Currently we'll only print metric headers for metric leader in
> > aggregration mode. This will make `perf iostat` header not shown
> > since it'll aggregrated globally but don't have metric events:
> > root@ubuntu204:/home/yang/linux/tools/perf# ./perf stat --iostat --timeout 1000
> >  Performance counter stats for 'system wide':
> >     port
> > 0000:00                    0                    0                    0                    0
> > 0000:80                    0                    0                    0                    0
> > [...]
> > 
> > Fix this by excluding the iostat in the check of printing metric
> > headers. Then we can see the headers:
> > root@ubuntu204:/home/yang/linux/tools/perf# ./perf stat --iostat --timeout 1000
> >  Performance counter stats for 'system wide':
> >     port             Inbound Read(MB)    Inbound Write(MB)    Outbound Read(MB)   Outbound Write(MB)
> > 0000:00                    0                    0                    0                    0
> > 0000:80                    0                    0                    0                    0
> > [...]
> > 
> > Fixes: 193a9e30207f ("perf stat: Don't display metric header for non-leader uncore events")
> > Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied to perf-tools-next,

- Arnaldo