All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<edumazet@google.com>, <netdev@vger.kernel.org>,
	Sriram Yagnaraman <sriram.yagnaraman@est.tech>,
	<magnus.karlsson@intel.com>, <ast@kernel.org>,
	<daniel@iogearbox.net>, <hawk@kernel.org>,
	<john.fastabend@gmail.com>, <bpf@vger.kernel.org>,
	<kurt@linutronix.de>, <sriram.yagnaraman@ericsson.com>,
	<richardcochran@gmail.com>, <benjamin.steinke@woks-audio.com>,
	<bigeasy@linutronix.de>,
	"Chandan Kumar Rout" <chandanx.rout@intel.com>
Subject: Re: [PATCH net-next 3/4] igb: add AF_XDP zero-copy Rx support
Date: Sat, 10 Aug 2024 16:12:07 +0200	[thread overview]
Message-ID: <Zrd1N4Bqh93eLfee@boxer> (raw)
In-Reply-To: <ZrdxPgcqLdzCXCAS@boxer>

On Sat, Aug 10, 2024 at 03:55:10PM +0200, Maciej Fijalkowski wrote:
> On Thu, Aug 08, 2024 at 11:35:53AM -0700, Tony Nguyen wrote:
> > From: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
> > 
> > Add support for AF_XDP zero-copy receive path.
> > 
> > When AF_XDP zero-copy is enabled, the rx buffers are allocated from the
> > xsk buff pool using igb_alloc_rx_buffers_zc.
> > 
> > Use xsk_pool_get_rx_frame_size to set SRRCTL rx buf size when zero-copy
> > is enabled.
> > 
> > Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
> > [Kurt: Port to v6.10 and provide napi_id for xdp_rxq_info_reg()]
> > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> > Tested-by: Chandan Kumar Rout <chandanx.rout@intel.com> (A Contingent Worker at Intel)
> > Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> > ---

> >  	netdev->priv_flags |= IFF_UNICAST_FLT;
> > -	netdev->xdp_features = NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT;
> > +	netdev->xdp_features = NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |
> > +			       NETDEV_XDP_ACT_XSK_ZEROCOPY;
> >  

Also please set this on last patch as this opens us to a state where
AF_XDP ZC is enabled but there is no Tx ZC yet.

  reply	other threads:[~2024-08-10 14:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-08 18:35 [PATCH net-next 0/4][pull request] igb: Add support for AF_XDP zero-copy Tony Nguyen
2024-08-08 18:35 ` [PATCH net-next 1/4] igb: prepare for AF_XDP zero-copy support Tony Nguyen
2024-08-08 20:38   ` Maciej Fijalkowski
2024-08-09 13:05     ` Kurt Kanzenbach
2024-08-09 13:14       ` Fijalkowski, Maciej
2024-08-09 13:19         ` Kurt Kanzenbach
2024-08-08 18:35 ` [PATCH net-next 2/4] igb: Introduce XSK data structures and helpers Tony Nguyen
2024-08-10 13:35   ` Maciej Fijalkowski
2024-08-08 18:35 ` [PATCH net-next 3/4] igb: add AF_XDP zero-copy Rx support Tony Nguyen
2024-08-10 13:55   ` Maciej Fijalkowski
2024-08-10 14:12     ` Maciej Fijalkowski [this message]
2024-08-14  8:29     ` Kurt Kanzenbach
2024-08-14  8:55       ` Maciej Fijalkowski
2024-08-08 18:35 ` [PATCH net-next 4/4] igb: add AF_XDP zero-copy Tx support Tony Nguyen
2024-08-10 14:10   ` Maciej Fijalkowski
2024-08-14  8:36     ` Kurt Kanzenbach
2024-08-14  8:55       ` Maciej Fijalkowski
2024-08-14  9:12         ` Kurt Kanzenbach
2024-08-14 10:26           ` Maciej Fijalkowski
2024-08-14 12:51             ` Kurt Kanzenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zrd1N4Bqh93eLfee@boxer \
    --to=maciej.fijalkowski@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ast@kernel.org \
    --cc=benjamin.steinke@woks-audio.com \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=chandanx.rout@intel.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=sriram.yagnaraman@ericsson.com \
    --cc=sriram.yagnaraman@est.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.