From: Andy Shevchenko <andy@kernel.org>
To: Lech Perczak <lech.perczak@camlingroup.com>
Cc: linux-serial@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Krzysztof Drobiński" <k.drobinski@camlintechnologies.com>,
"Pawel Lenkow" <p.lenkow@camlintechnologies.com>,
"Kirill Yatsenko" <kirill.yatsenko@camlingroup.com>
Subject: Re: [PATCH v2 2/3] serial: sc16is7xx: fix copy-paste errors in EFR_SWFLOWx_BIT macros
Date: Mon, 12 Aug 2024 20:08:57 +0300 [thread overview]
Message-ID: <ZrpBqaZVCNXtb3zv@smile.fi.intel.com> (raw)
In-Reply-To: <497a8d04-665b-410c-aad6-e1a05869c744@camlingroup.com>
On Mon, Aug 12, 2024 at 06:56:02PM +0200, Lech Perczak wrote:
> Comments attached to bits 0 and 1 incorrectly referenced bits 2 and 3,
> which don't match the datasheet - fix them.
> At the same time remove comments for individual macros, as they add
> nothing to the definitions themselves.
Strictly speaking we use term "definitions" or "constants" for the defined
constants instead of "macros" (see Subject).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-12 17:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 16:53 [PATCH v2 0/3] serial: sc16is7xx: cosmetic cleanup Lech Perczak
2024-08-12 16:54 ` [PATCH v2 1/3] serial: sc16is7xx: remove SC16IS7XX_MSR_DELTA_MASK Lech Perczak
2024-08-12 17:09 ` Andy Shevchenko
2024-08-12 16:56 ` [PATCH v2 2/3] serial: sc16is7xx: fix copy-paste errors in EFR_SWFLOWx_BIT macros Lech Perczak
2024-08-12 17:08 ` Andy Shevchenko [this message]
2024-08-12 16:56 ` [PATCH v2 3/3] serial: sc16is7xx: convert bitmask definitions to use BIT macro Lech Perczak
2024-08-12 17:08 ` Andy Shevchenko
2024-08-13 8:30 ` Ilpo Järvinen
2024-08-13 13:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrpBqaZVCNXtb3zv@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=k.drobinski@camlintechnologies.com \
--cc=kirill.yatsenko@camlingroup.com \
--cc=lech.perczak@camlingroup.com \
--cc=linux-serial@vger.kernel.org \
--cc=p.lenkow@camlintechnologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.