From: Namhyung Kim <namhyung@kernel.org>
To: Yang Jihong <yangjihong@bytedance.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, james.clark@arm.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] perf sched timehist: Remove BUG_ON in timehist_sched_change_event()
Date: Mon, 12 Aug 2024 12:04:03 -0700 [thread overview]
Message-ID: <Zrpco5rOa9n7S5RN@google.com> (raw)
In-Reply-To: <20240812132606.3126490-2-yangjihong@bytedance.com>
On Mon, Aug 12, 2024 at 09:26:06PM +0800, Yang Jihong wrote:
> The BUG_ON(thread__tid(thread) != 0) in timehist_sched_change_event()
> is redundant, remove it.
> No functional change.
>
> Fixes: 07235f84ece6 ("perf sched timehist: Add -I/--idle-hist option")
> Signed-off-by: Yang Jihong <yangjihong@bytedance.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/builtin-sched.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 177634df1ba5..309dcfb3796d 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -2700,8 +2700,6 @@ static int timehist_sched_change_event(struct perf_tool *tool,
> struct idle_thread_runtime *itr = (void *)tr;
> struct thread_runtime *last_tr;
>
> - BUG_ON(thread__tid(thread) != 0);
> -
> if (itr->last_thread == NULL)
> goto out;
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2024-08-12 19:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 13:26 [PATCH v2 1/2] perf sched timehist: Skip print non-idle task samples when only show idle events Yang Jihong
2024-08-12 13:26 ` [PATCH v2 2/2] perf sched timehist: Remove BUG_ON in timehist_sched_change_event() Yang Jihong
2024-08-12 19:04 ` Namhyung Kim [this message]
2024-08-14 18:42 ` Madadi Vineeth Reddy
2024-08-12 19:03 ` [PATCH v2 1/2] perf sched timehist: Skip print non-idle task samples when only show idle events Namhyung Kim
2024-09-03 18:44 ` Arnaldo Carvalho de Melo
2024-08-14 18:38 ` Madadi Vineeth Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zrpco5rOa9n7S5RN@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yangjihong@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.