From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: weilin.wang@intel.com
Cc: Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Perry Taylor <perry.taylor@intel.com>,
Samantha Alt <samantha.alt@intel.com>,
Caleb Biggers <caleb.biggers@intel.com>
Subject: Re: [RFC PATCH v18 8/8] perf test: Add test for Intel TPEBS counting mode
Date: Mon, 12 Aug 2024 22:24:37 -0300 [thread overview]
Message-ID: <Zrq11fq_F9vImsQh@x1> (raw)
In-Reply-To: <20240720062102.444578-9-weilin.wang@intel.com>
On Sat, Jul 20, 2024 at 02:21:01AM -0400, weilin.wang@intel.com wrote:
> From: Weilin Wang <weilin.wang@intel.com>
>
> Intel TPEBS sampling mode is supported through perf record. The counting mode
> code uses perf record to capture retire_latency value and use it in metric
> calculation. This test checks the counting mode code on Intel platforms.
root@x1:~# perf test -vvvvv 123
123: test Intel TPEBS counting mode:
--- start ---
test child forked, pid 2600160
Testing without --record-tpebs
Testing with --record-tpebs
---- end(-1) ----
123: test Intel TPEBS counting mode : FAILED!
root@x1:~# grep -m1 "model name" /proc/cpuinfo
model name : 13th Gen Intel(R) Core(TM) i7-1365U
root@x1:~#
What am I missing?
The current codebase is in tmp.perf-tools-next
- Arnaldo
> Signed-off-by: Weilin Wang <weilin.wang@intel.com>
> ---
> .../perf/tests/shell/test_stat_intel_tpebs.sh | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100755 tools/perf/tests/shell/test_stat_intel_tpebs.sh
>
> diff --git a/tools/perf/tests/shell/test_stat_intel_tpebs.sh b/tools/perf/tests/shell/test_stat_intel_tpebs.sh
> new file mode 100755
> index 000000000000..c60b29add980
> --- /dev/null
> +++ b/tools/perf/tests/shell/test_stat_intel_tpebs.sh
> @@ -0,0 +1,19 @@
> +#!/bin/bash
> +# test Intel TPEBS counting mode
> +# SPDX-License-Identifier: GPL-2.0
> +
> +set -e
> +grep -q GenuineIntel /proc/cpuinfo || { echo Skipping non-Intel; exit 2; }
> +
> +# Use this event for testing because it should exist in all platforms
> +event=cache-misses:R
> +
> +# Without this cmd option, default value or zero is returned
> +echo "Testing without --record-tpebs"
> +result=$(perf stat -e "$event" true 2>&1)
> +[[ "$result" =~ $event ]] || exit 1
> +
> +# In platforms that do not support TPEBS, it should execute without error.
> +echo "Testing with --record-tpebs"
> +result=$(perf stat -e "$event" --record-tpebs -a sleep 0.01 2>&1)
> +[[ "$result" =~ "perf record" && "$result" =~ $event ]] || exit 1
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-08-13 1:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-20 6:20 [RFC PATCH v18 0/8] TPEBS counting mode support weilin.wang
2024-07-20 6:20 ` [RFC PATCH v18 1/8] perf parse-events: Add a retirement latency modifier weilin.wang
2024-07-20 6:20 ` [RFC PATCH v18 2/8] perf data: Allow to use given fd in data->file.fd weilin.wang
2024-07-20 6:20 ` [RFC PATCH v18 3/8] perf stat: Fork and launch perf record when perf stat needs to get retire latency value for a metric weilin.wang
2024-08-05 19:40 ` Arnaldo Carvalho de Melo
2024-08-05 19:43 ` Arnaldo Carvalho de Melo
2024-08-05 20:19 ` Wang, Weilin
2024-08-05 20:20 ` Arnaldo Carvalho de Melo
2024-08-05 20:34 ` Wang, Weilin
2024-07-20 6:20 ` [RFC PATCH v18 4/8] perf stat: Plugin retire_lat value from sampled data to evsel weilin.wang
2024-07-20 6:20 ` [RFC PATCH v18 5/8] perf vendor events intel: Add MTL metric json files weilin.wang
2024-07-20 6:20 ` [RFC PATCH v18 6/8] perf stat: Add command line option for enabling tpebs recording weilin.wang
2024-07-20 6:21 ` [RFC PATCH v18 7/8] perf Document: Add TPEBS to Documents weilin.wang
2024-07-20 6:21 ` [RFC PATCH v18 8/8] perf test: Add test for Intel TPEBS counting mode weilin.wang
2024-08-13 1:24 ` Arnaldo Carvalho de Melo [this message]
2024-08-13 1:25 ` Arnaldo Carvalho de Melo
2024-08-13 17:18 ` Wang, Weilin
2024-08-13 17:48 ` Ian Rogers
2024-08-13 18:27 ` Arnaldo Carvalho de Melo
2024-08-13 18:36 ` Arnaldo Carvalho de Melo
2024-07-22 17:37 ` [RFC PATCH v18 0/8] TPEBS counting mode support Namhyung Kim
2024-08-05 15:10 ` Ian Rogers
2024-08-05 19:33 ` Arnaldo Carvalho de Melo
2024-08-05 23:33 ` Ian Rogers
2024-08-06 13:32 ` Arnaldo Carvalho de Melo
2024-08-06 14:35 ` Ian Rogers
2024-08-12 15:38 ` Ian Rogers
2024-08-12 16:35 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zrq11fq_F9vImsQh@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
--cc=weilin.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.