From: Andi Kleen <ak@linux.intel.com>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, adobriyan@gmail.com,
shakeel.butt@linux.dev, hannes@cmpxchg.org, osandov@osandov.com,
song@kernel.org, jannh@google.com, linux-fsdevel@vger.kernel.org,
willy@infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH v5 bpf-next 01/10] lib/buildid: harden build ID parsing logic
Date: Mon, 12 Aug 2024 17:52:00 -0700 [thread overview]
Message-ID: <ZrquMOQc8vAjYxIB@tassilo> (raw)
In-Reply-To: <20240813002932.3373935-2-andrii@kernel.org>
> @@ -152,6 +160,10 @@ int build_id_parse(struct vm_area_struct *vma, unsigned char *build_id,
> page = find_get_page(vma->vm_file->f_mapping, 0);
> if (!page)
> return -EFAULT; /* page not mapped */
> + if (!PageUptodate(page)) {
> + put_page(page);
> + return -EFAULT;
> + }
That change is not described. As I understand it might prevent reading
previous data in the page or maybe junk under an IO error? Anyways I guess it's a
good change.
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
next prev parent reply other threads:[~2024-08-13 0:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 0:29 [PATCH v5 bpf-next 00/10] Harden and extend ELF build ID parsing logic Andrii Nakryiko
2024-08-13 0:29 ` [PATCH v5 bpf-next 01/10] lib/buildid: harden " Andrii Nakryiko
2024-08-13 0:52 ` Andi Kleen [this message]
2024-08-13 3:06 ` Andrii Nakryiko
2024-08-13 20:59 ` Jann Horn
2024-08-13 23:21 ` Andrii Nakryiko
2024-08-14 16:13 ` Jann Horn
2024-08-14 17:06 ` Andrii Nakryiko
2024-08-13 0:29 ` [PATCH v5 bpf-next 02/10] lib/buildid: add single folio-based file reader abstraction Andrii Nakryiko
2024-08-13 0:29 ` [PATCH v5 bpf-next 03/10] lib/buildid: take into account e_phoff when fetching program headers Andrii Nakryiko
2024-08-13 0:29 ` [PATCH v5 bpf-next 04/10] lib/buildid: remove single-page limit for PHDR search Andrii Nakryiko
2024-08-13 0:29 ` [PATCH v5 bpf-next 05/10] lib/buildid: rename build_id_parse() into build_id_parse_nofault() Andrii Nakryiko
2024-08-13 0:29 ` [PATCH v5 bpf-next 06/10] lib/buildid: implement sleepable build_id_parse() API Andrii Nakryiko
2024-08-13 17:26 ` Shakeel Butt
2024-08-13 0:29 ` [PATCH v5 bpf-next 07/10] lib/buildid: don't limit .note.gnu.build-id to the first page in ELF Andrii Nakryiko
2024-08-13 0:29 ` [PATCH v5 bpf-next 08/10] bpf: decouple stack_map_get_build_id_offset() from perf_callchain_entry Andrii Nakryiko
2024-08-13 0:29 ` [PATCH v5 bpf-next 09/10] bpf: wire up sleepable bpf_get_stack() and bpf_get_task_stack() helpers Andrii Nakryiko
2024-08-13 1:05 ` Andi Kleen
2024-08-13 3:11 ` Andrii Nakryiko
2024-08-13 0:29 ` [PATCH v5 bpf-next 10/10] selftests/bpf: add build ID tests Andrii Nakryiko
2024-08-13 1:05 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrquMOQc8vAjYxIB@tassilo \
--to=ak@linux.intel.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jannh@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osandov@osandov.com \
--cc=shakeel.butt@linux.dev \
--cc=song@kernel.org \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.